ServiceException uses psuedorandom error instance UUIDs (#1158)

ServiceException uses psuedorandom error instance UUIDs

Author: schlosna

changelog/@unreleased/pr-1158.v2.yml

@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: ServiceException uses psuedorandom error instance UUIDs
+  links:
+  - https://github.com/palantir/conjure-java-runtime-api/pull/1158

errors/build.gradle

@@ -5,15 +5,16 @@ apply plugin: 'com.palantir.revapi'
 
 dependencies {
     annotationProcessor "org.immutables:value"
-    
+
     compileOnlyApi 'org.immutables:value::annotations'
-    
+
     api "com.fasterxml.jackson.core:jackson-databind"
     api "com.google.code.findbugs:jsr305"
     api "com.palantir.safe-logging:safe-logging"
     api "org.jetbrains:annotations"
-    
+
     implementation "com.palantir.safe-logging:preconditions"
+    implementation "com.palantir.tritium:tritium-ids"
 
     testImplementation project(":extras:jackson-support")
     testImplementation "com.palantir.safe-logging:preconditions-assertj"

errors/src/main/java/com/palantir/conjure/java/api/errors/ServiceException.java

@@ -18,12 +18,12 @@
 
 import com.palantir.logsafe.Arg;
 import com.palantir.logsafe.SafeLoggable;
+import com.palantir.tritium.ids.UniqueIds;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.IdentityHashMap;
 import java.util.List;
 import java.util.Set;
-import java.util.UUID;
 import javax.annotation.Nullable;
 
 /** A {@link ServiceException} thrown in server-side code to indicate server-side {@link ErrorType error states}. */
@@ -150,7 +150,8 @@ private static String generateErrorInstanceId(
             // Guard against cause cycles, see Throwable.printStackTrace(PrintStreamOrWriter)
             Set<Throwable> dejaVu) {
         if (cause == null || !dejaVu.add(cause)) {
-            return UUID.randomUUID().toString();
+            // we don't need cryptographically secure random UUIDs
+            return UniqueIds.pseudoRandomUuidV4().toString();
         }
         if (cause instanceof ServiceException) {
             return ((ServiceException) cause).getErrorInstanceId();

versions.lock

@@ -7,20 +7,22 @@ com.fasterxml.jackson.datatype:jackson-datatype-guava:2.16.1 (1 constraints: 3c0
 com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.16.1 (1 constraints: 3c05423b)
 com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.16.1 (1 constraints: 3c05423b)
 com.google.code.findbugs:jsr305:3.0.2 (2 constraints: 1d0fb186)
-com.google.errorprone:error_prone_annotations:2.23.0 (5 constraints: 6649c862)
-com.google.guava:guava:25.1-jre (1 constraints: b117853a)
-com.google.j2objc:j2objc-annotations:1.1 (1 constraints: b609eba0)
-com.palantir.safe-logging:logger:3.7.0 (2 constraints: e1125a37)
+com.google.errorprone:error_prone_annotations:2.26.1 (5 constraints: 9b497093)
+com.google.guava:failureaccess:1.0.2 (1 constraints: 150ae2b4)
+com.google.guava:guava:33.1.0-jre (2 constraints: a627a813)
+com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava (1 constraints: bd17c918)
+com.google.j2objc:j2objc-annotations:3.0.0 (1 constraints: 150aeab4)
+com.palantir.safe-logging:logger:3.7.0 (3 constraints: 3b21bf88)
 com.palantir.safe-logging:logger-slf4j:3.7.0 (1 constraints: 050e6842)
 com.palantir.safe-logging:logger-spi:3.7.0 (2 constraints: 191ea27b)
-com.palantir.safe-logging:preconditions:3.7.0 (3 constraints: 0f2749de)
+com.palantir.safe-logging:preconditions:3.7.0 (4 constraints: 6935486b)
 com.palantir.safe-logging:safe-logging:3.7.0 (5 constraints: c0471e0e)
 com.palantir.tokens:auth-tokens:3.18.0 (1 constraints: 3e054d3b)
+com.palantir.tritium:tritium-ids:0.87.0 (1 constraints: 4105543b)
 net.bytebuddy:byte-buddy:1.14.12 (2 constraints: f016bb66)
 net.bytebuddy:byte-buddy-agent:1.14.12 (1 constraints: 730bb2e9)
 org.assertj:assertj-core:3.25.3 (2 constraints: 9e19a0df)
-org.checkerframework:checker-qual:2.0.0 (1 constraints: 140ae5b4)
-org.codehaus.mojo:animal-sniffer-annotations:1.14 (1 constraints: ea09d5aa)
+org.checkerframework:checker-qual:3.42.0 (1 constraints: 4b0a47bf)
 org.immutables:value:2.10.1 (1 constraints: 3605303b)
 org.jetbrains:annotations:24.1.0 (1 constraints: 331166d1)
 org.mockito:mockito-core:5.11.0 (1 constraints: 3905443b)

versions.props

@@ -3,6 +3,7 @@ com.fasterxml.jackson.core:jackson-databind = 2.16.1
 com.google.code.findbugs:jsr305 = 3.0.2
 com.palantir.safe-logging:* = 3.7.0
 com.palantir.tokens:auth-tokens = 3.18.0
+com.palantir.tritium:* = 0.87.0
 org.apache.commons:commons-lang3 = 3.14.0
 org.assertj:assertj-core = 3.25.3
 org.immutables:* = 2.10.1