Test coverage for SerializableError.forException() with Optional values (#1051)

Test coverage for SerializableError.forException() with Optional values

Author: ash211

errors/src/test/java/com/palantir/conjure/java/api/errors/SerializableErrorTest.java

@@ -26,6 +26,7 @@
 import java.io.IOException;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 import java.util.regex.Pattern;
 import org.junit.jupiter.api.Test;
 
@@ -125,6 +126,24 @@ public void forException_mapArrayArgValue_serializesWithToString() {
                                 assertThat(value).matches(Pattern.quote("[Ljava.lang.String;@") + "[0-9a-f]+"));
     }
 
+    @Test
+    public void forException_optionalArgValue_serializesWithToString() {
+        ErrorType error = ErrorType.INTERNAL;
+        ServiceException exception = new ServiceException(
+                error,
+                SafeArg.of("safe-optional-present", Optional.of("hello")),
+                UnsafeArg.of("unsafe-optional-empty", Optional.empty()));
+
+        SerializableError expected = new SerializableError.Builder()
+                .errorCode(error.code().name())
+                .errorName(error.name())
+                .errorInstanceId(exception.getErrorInstanceId())
+                .putParameters("safe-optional-present", "Optional[hello]")
+                .putParameters("unsafe-optional-empty", "Optional.empty")
+                .build();
+        assertThat(SerializableError.forException(exception)).isEqualTo(expected);
+    }
+
     @Test
     public void testSerializationContainsRedundantParameters() throws Exception {
         assertThat(mapper.writeValueAsString(ERROR))