fix style and scrutinizer advices.

Author: lopadova

src/ComposerSecurityCheckServiceProvider.php

@@ -50,7 +50,7 @@ function ($app) {
     /**
      * Get the services provided by the provider.
      *
-     * @return array
+     * @return string[]
      */
     public function provides()
     {

src/SensiolabHelper.php

@@ -80,7 +80,9 @@ public function getSensiolabVulnerabilties($fileLock)
             $colorTag = $this->getColorTagForStatusCode($e->getResponse()->getStatusCode());
             $this->command->line("HTTP StatusCode: <{$colorTag}>" . $e->getResponse()->getStatusCode() . "<{$colorTag}>");
             $resp = $e->getResponse();
-            $this->printMessage($resp === null ? '' : $resp);
+            if ($resp != null) {
+                $this->printMessage($resp);
+            }
             $this->printMessage($e->getRequest());
         } catch (\GuzzleHttp\Exception\RequestException $e) {
             $this->command->error("RequestException!\nMessage: " . $e->getMessage());
@@ -89,7 +91,9 @@ public function getSensiolabVulnerabilties($fileLock)
                 $colorTag = $this->getColorTagForStatusCode($e->getResponse()->getStatusCode());
                 $this->command->line("HTTP StatusCode: <{$colorTag}>" . $e->getResponse()->getStatusCode() . "<{$colorTag}>");
                 $resp = $e->getResponse();
-                $this->printMessage($resp === null ? '' : $resp);
+                if ($resp != null) {
+                    $this->printMessage($resp);
+                }
             }
         }
         return $response;
@@ -131,7 +135,7 @@ public function parseVulnerability($name, $vulnerability)
     /**
      * @param $key
      * @param $vulnerability
-     * @param $tuttoOk
+     * @param bool $tuttoOk
      * @return array
      */
     public function checkResponse($key, $vulnerability, $tuttoOk)
@@ -146,7 +150,7 @@ public function checkResponse($key, $vulnerability, $tuttoOk)
     }
 
     /**
-     * @param            $msg
+     * @param string $msg
      * @param bool|false $error
      */
     private function addVerboseLog($msg, $error = false)
@@ -169,14 +173,13 @@ private function addVerboseLog($msg, $error = false)
     private function printMessage(\Psr\Http\Message\MessageInterface $message)
     {
         $type = '';
+        $body = '';
         if (is_a($message, '\Psr\Http\Message\RequestInterface')) {
             $type = 'REQUEST';
             $body = $message->getBody();
-        } else {
-            if (is_a($message, '\Psr\Http\Message\ResponseInterface')) {
-                $type = 'RESPONSE';
-                $body = $message->getBody()->getContents();
-            }
+        } elseif (is_a($message, '\Psr\Http\Message\ResponseInterface')) {
+            $type = 'RESPONSE';
+            $body = $message->getBody()->getContents();
         }
         $this->command->info("$type:");
         $headers = '';
@@ -186,10 +189,8 @@ private function printMessage(\Psr\Http\Message\MessageInterface $message)
         $this->command->comment($headers);
         if ($type == 'REQUEST') {
             $this->command->comment($body);
-        } else {
-            if ($type == 'RESPONSE') {
-                $this->command->comment($body);
-            }
+        } elseif ($type == 'RESPONSE') {
+            $this->command->comment($body);
         }
     }
 

src/config/composer-security-check.php

@@ -11,5 +11,5 @@
     'mailFrom' => env('SECURITY_CHECK_MESSAGE_FROM', '[email protected]'),
     'mailFromName' => env('SECURITY_CHECK_MESSAGE_FROM_NAME', 'Info Example'),
     'mailViewName' => env('SECURITY_CHECK_MAIL_VIEW_NAME', 'composer-security-check::mail'),
-    'logFilePath' => env('SECURITY_CHECK_LOG_FILE_PATH', storage_path().'/logs/composersecurityCheck.log')
- );
+    'logFilePath' => env('SECURITY_CHECK_LOG_FILE_PATH', storage_path() . '/logs/composersecurityCheck.log')
+);