Skip to content

deleted colors #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kubiqsk opened this issue Jan 12, 2022 · 7 comments
Closed

deleted colors #22

kubiqsk opened this issue Jan 12, 2022 · 7 comments

Comments

@kubiqsk
Copy link

kubiqsk commented Jan 12, 2022

when there are expressions like
background-color: rgba(var(--bs-primary-rgb), var(--bs-bg-opacity)) !important;
or
color: rgba(var(--bs-body-color-rgb), var(--bs-text-opacity)) !important;
then it will complete delete them

@Ruud68
Copy link
Contributor

Ruud68 commented Jan 13, 2022

Okay, just had a look at this one.
This is not an issue with this repo but an issue with the sabberworm repo that this repo uses.

there is a fix that will be in the latest release (not released yet): MyIntervals/PHP-CSS-Parser#257

@kubiqsk
Copy link
Author

kubiqsk commented Jan 13, 2022

I did output also compiled CSS before autoprefixing and it contains all needed expressions
https://scss.kubiq.sk/style-unprefixed.css
so i'm pretty sure, it's actually issue in here

@kubiqsk
Copy link
Author

kubiqsk commented Jan 13, 2022

after that i just take this and

$autoprefixer = new Autoprefixer( $unprefixed_css );
$prefixed_css = $autoprefixer->compile();
file_put_contents( 'style.css', $prefixed_css );

and after that, there are no more these values
https://scss.kubiq.sk/style.css

@padaliyajay
Copy link
Owner

he mean "PHP-CSS-Parser" repo, and not SCSS repo. @kubiqsk

@kubiqsk
Copy link
Author

kubiqsk commented Jan 13, 2022

you're right! Sorry
But it's more than 6 months old
and they say it's solved in 8.3.1 (which is not officially released?)

@kubiqsk
Copy link
Author

kubiqsk commented Jan 13, 2022

so yes, when I download ZIP of https://github.com/sabberworm/PHP-CSS-Parser and replace it in /vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/ then everything works

@Ruud68
Copy link
Contributor

Ruud68 commented Jan 13, 2022

I thing that the sabberworm repo is not yet made available (version 8.4), not sure what the status / delay is.
While testing this I found also other issue reported here: MyIntervals/PHP-CSS-Parser#357
for BS5 css that is no issue, but when you apply codestyle and break long lines onto multiple lines then you might have an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants