From 22fdc4aa8c9e11b07a17c88dba8d585dfcc3b530 Mon Sep 17 00:00:00 2001 From: Sysix <3897725+Sysix@users.noreply.github.com> Date: Mon, 8 Dec 2025 23:00:51 +0000 Subject: [PATCH] chore(lsp): rename `remove_diagnostics` to `remove_uri_cache` (#16614) Renaming the method to make it more clear. There is no diagnostic anymore to be removed. Instead remove the cache of an given URI. --- crates/oxc_language_server/src/backend.rs | 2 +- crates/oxc_language_server/src/linter/server_linter.rs | 2 +- crates/oxc_language_server/src/tool.rs | 4 ++-- crates/oxc_language_server/src/worker.rs | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/crates/oxc_language_server/src/backend.rs b/crates/oxc_language_server/src/backend.rs index d51cb3f524d12..3fae30fe3175c 100644 --- a/crates/oxc_language_server/src/backend.rs +++ b/crates/oxc_language_server/src/backend.rs @@ -566,7 +566,7 @@ impl LanguageServer for Backend { }; self.file_system.write().await.remove(uri); - worker.remove_diagnostics(¶ms.text_document.uri).await; + worker.remove_uri_cache(¶ms.text_document.uri).await; } /// It will return code actions or commands for the given range. diff --git a/crates/oxc_language_server/src/linter/server_linter.rs b/crates/oxc_language_server/src/linter/server_linter.rs index a1d1df8fc2ddf..8f4af0fcd002b 100644 --- a/crates/oxc_language_server/src/linter/server_linter.rs +++ b/crates/oxc_language_server/src/linter/server_linter.rs @@ -525,7 +525,7 @@ impl Tool for ServerLinter { self.run_diagnostic(uri, content) } - fn remove_diagnostics(&self, uri: &Uri) { + fn remove_uri_cache(&self, uri: &Uri) { self.code_actions.pin().remove(uri); } } diff --git a/crates/oxc_language_server/src/tool.rs b/crates/oxc_language_server/src/tool.rs index 658540cb7e36d..85692e3f10793 100644 --- a/crates/oxc_language_server/src/tool.rs +++ b/crates/oxc_language_server/src/tool.rs @@ -114,8 +114,8 @@ pub trait Tool: Send + Sync { None } - /// Remove diagnostics associated with the given URI. - fn remove_diagnostics(&self, _uri: &Uri) { + /// Remove internal cache for the given URI, if any. + fn remove_uri_cache(&self, _uri: &Uri) { // Default implementation does nothing. } diff --git a/crates/oxc_language_server/src/worker.rs b/crates/oxc_language_server/src/worker.rs index 413030653f3e6..9a4915ef45bee 100644 --- a/crates/oxc_language_server/src/worker.rs +++ b/crates/oxc_language_server/src/worker.rs @@ -94,10 +94,10 @@ impl WorkspaceWorker { self.options.lock().await.is_none() } - /// Remove all diagnostics for the given URI - pub async fn remove_diagnostics(&self, uri: &Uri) { + /// Remove all internal cache for the given URI, if any. + pub async fn remove_uri_cache(&self, uri: &Uri) { self.tools.read().await.iter().for_each(|tool| { - tool.remove_diagnostics(uri); + tool.remove_uri_cache(uri); }); }