feat: add disable space option in bottom sheet dialog for users with proper permissions

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/extensions/SpaceMenuOptionExt.kt

@@ -26,9 +26,11 @@ import com.owncloud.android.domain.spaces.model.SpaceMenuOption
 fun SpaceMenuOption.toStringResId() =
     when (this) {
         SpaceMenuOption.EDIT -> R.string.edit_space
+        SpaceMenuOption.DISABLE -> R.string.disable_space
     }
 
 fun SpaceMenuOption.toDrawableResId() =
     when (this) {
         SpaceMenuOption.EDIT -> R.drawable.ic_pencil
+        SpaceMenuOption.DISABLE -> R.drawable.ic_disable_space
     }

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt

@@ -22,6 +22,7 @@
 
 package com.owncloud.android.presentation.spaces
 
+import android.content.DialogInterface
 import android.content.res.Configuration
 import android.os.Bundle
 import android.view.LayoutInflater
@@ -46,6 +47,7 @@ import com.owncloud.android.domain.spaces.model.OCSpace
 import com.owncloud.android.domain.spaces.model.SpaceMenuOption
 import com.owncloud.android.domain.user.model.UserPermissions
 import com.owncloud.android.extensions.collectLatestLifecycleFlow
+import com.owncloud.android.extensions.showAlertDialog
 import com.owncloud.android.extensions.showErrorInSnackbar
 import com.owncloud.android.extensions.showMessageInSnackbar
 import com.owncloud.android.extensions.toDrawableRes
@@ -184,6 +186,7 @@ class SpacesListFragment :
                             binding.fabCreateSpace.isVisible = it.contains(DRIVES_CREATE_ALL_PERMISSION)
                             if(it.contains(DRIVES_READ_WRITE_ALL_PERMISSION)) userPermissions.add(UserPermissions.CAN_EDIT_SPACES)
                             editQuotaPermission = it.contains(DRIVES_READ_WRITE_PROJECT_QUOTA_ALL_PERMISSION)
+                            if(it.contains(DRIVES_DELETE_PROJECT_ALL_PERMISSION)) userPermissions.add(UserPermissions.CAN_DELETE_SPACES)
                         }
                     }
                     is UIResult.Loading -> { }
@@ -338,6 +341,15 @@ class SpacesListFragment :
                         )
                         editDialog.show(requireActivity().supportFragmentManager, DIALOG_CREATE_SPACE)
                     }
+                    SpaceMenuOption.DISABLE -> {
+                        showAlertDialog(
+                            title = getString(R.string.disable_space_dialog_title, currentSpace.name),
+                            message = getString(R.string.disable_space_dialog_message),
+                            positiveButtonText = getString(R.string.common_yes),
+                            positiveButtonListener = { _: DialogInterface?, _: Int -> },
+                            negativeButtonText = getString(R.string.common_no)
+                        )
+                    }
                 }
             }
         }
@@ -352,6 +364,7 @@ class SpacesListFragment :
         const val DRIVES_CREATE_ALL_PERMISSION = "Drives.Create.all"
         const val DRIVES_READ_WRITE_ALL_PERMISSION = "Drives.ReadWrite.all"
         const val DRIVES_READ_WRITE_PROJECT_QUOTA_ALL_PERMISSION = "Drives.ReadWriteProjectQuota.all"
+        const val DRIVES_DELETE_PROJECT_ALL_PERMISSION = "Drives.DeleteProject.all"
 
         private const val DIALOG_CREATE_SPACE = "DIALOG_CREATE_SPACE"
 

owncloudApp/src/main/res/drawable/ic_disable_space.xml

@@ -0,0 +1,10 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:viewportWidth="960"
+    android:viewportHeight="960"
+    android:tint="?attr/colorControlNormal">
+    <path
+        android:fillColor="@android:color/white"
+        android:pathData="M320,640L640,640L640,320L320,320L320,640ZM480,880Q397,880 324,848.5Q251,817 197,763Q143,709 111.5,636Q80,563 80,480Q80,397 111.5,324Q143,251 197,197Q251,143 324,111.5Q397,80 480,80Q563,80 636,111.5Q709,143 763,197Q817,251 848.5,324Q880,397 880,480Q880,563 848.5,636Q817,709 763,763Q709,817 636,848.5Q563,880 480,880ZM480,800Q614,800 707,707Q800,614 800,480Q800,346 707,253Q614,160 480,160Q346,160 253,253Q160,346 160,480Q160,614 253,707Q346,800 480,800ZM480,480Q480,480 480,480Q480,480 480,480Q480,480 480,480Q480,480 480,480Q480,480 480,480Q480,480 480,480Q480,480 480,480Q480,480 480,480Z"/>
+</vector>

owncloudApp/src/main/res/values/strings.xml

@@ -853,6 +853,9 @@
     <string name="edit_space">Edit space</string>
     <string name="edit_space_correctly">Space updated correctly</string>
     <string name="edit_space_failed">Space could not be updated</string>
+    <string name="disable_space">Disable space</string>
+    <string name="disable_space_dialog_title">Do you really want to disable the space: %1$s?</string>
+    <string name="disable_space_dialog_message">If you disable the selected space, it can no longer be accessed. Only Space managers will still have access. Note: No files will be deleted from the server.</string>
 
     <string name="feedback_dialog_get_in_contact_description"><![CDATA[ Ask for help in our <a href=\"%1$s\"><b>forum</b></a> or contribute in our <a href=\"%2$s\"><b>GitHub repo</b></a>]]></string>
 

owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/model/SpaceMenuOption.kt

@@ -21,5 +21,5 @@
 package com.owncloud.android.domain.spaces.model
 
 enum class SpaceMenuOption {
-    EDIT
+    EDIT, DISABLE
 }

owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/usecases/FilterSpaceMenuOptionsUseCase.kt

@@ -38,10 +38,17 @@ class FilterSpaceMenuOptionsUseCase(
         val editPermission =
             (UserPermissions.CAN_EDIT_SPACES in params.userPermissions || hasSpacePermission(spacePermissionsResult, DRIVES_MANAGE_PERMISSION))
 
+        val deletePermission =
+            (UserPermissions.CAN_DELETE_SPACES in params.userPermissions || hasSpacePermission(spacePermissionsResult, DRIVES_DELETE_PERMISSION))
+
         if (editPermission) {
             optionsToShow.add(SpaceMenuOption.EDIT)
         }
 
+        if (!params.space.isDisabled && deletePermission) {
+            optionsToShow.add(SpaceMenuOption.DISABLE)
+        }
+
         return optionsToShow
     }
 
@@ -59,5 +66,6 @@ class FilterSpaceMenuOptionsUseCase(
 
     companion object {
         private const val DRIVES_MANAGE_PERMISSION = "libre.graph/driveItem/permissions/update"
+        private const val DRIVES_DELETE_PERMISSION = "libre.graph/driveItem/permissions/delete"
     }
 }

owncloudDomain/src/main/java/com/owncloud/android/domain/user/model/UserPermissions.kt

@@ -21,5 +21,5 @@
 package com.owncloud.android.domain.user.model
 
 enum class UserPermissions {
-    CAN_EDIT_SPACES
+    CAN_EDIT_SPACES, CAN_DELETE_SPACES
 }