fix: hide icons when user loses permissions

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersAdapter.kt

@@ -31,7 +31,6 @@ import com.owncloud.android.databinding.MemberItemBinding
 import com.owncloud.android.domain.roles.model.OCRole
 import com.owncloud.android.domain.roles.model.OCRoleType
 import com.owncloud.android.domain.spaces.model.SpaceMember
-import com.owncloud.android.domain.spaces.model.SpaceMembers
 import com.owncloud.android.utils.DisplayUtils
 import com.owncloud.android.utils.PreferenceUtils
 
@@ -97,13 +96,23 @@ class SpaceMembersAdapter(
 
     override fun getItemCount(): Int = members.size
 
-    fun setSpaceMembers(spaceMembers: SpaceMembers, roles: List<OCRole>, canRemoveMembers: Boolean, canEditMembers: Boolean, numberOfManagers: Int) {
+    fun setSpaceMembers(
+        spaceMembers: List<SpaceMember>,
+        roles: List<OCRole>,
+        canRemoveMembers: Boolean,
+        canEditMembers: Boolean,
+        numberOfManagers: Int
+    ) {
+
+        val userPermissionsChanged = this.canEditMembers != canEditMembers
+        val numberOfManagersChanged = this.numberOfManagers != numberOfManagers
+
         this.canRemoveMembers = canRemoveMembers
         this.canEditMembers = canEditMembers
         this.rolesMap = roles.associate { it.id to it.displayName }
-        val listOfMembersFiltered = spaceMembers.members.sortedWith(compareByDescending<SpaceMember> {
+        val listOfMembersFiltered = spaceMembers.sortedWith(compareByDescending<SpaceMember> {
                 member -> roles.indexOfFirst { it.id in member.roles } }.thenBy { member -> member.displayName })
-        val diffCallback = SpaceMembersDiffUtil(this.members, listOfMembersFiltered, this.numberOfManagers, numberOfManagers)
+        val diffCallback = SpaceMembersDiffUtil(this.members, listOfMembersFiltered, numberOfManagersChanged, userPermissionsChanged)
         val diffResult = DiffUtil.calculateDiff(diffCallback)
         this.members = listOfMembersFiltered
         this.numberOfManagers = numberOfManagers

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersDiffUtil.kt

@@ -26,8 +26,8 @@ import com.owncloud.android.domain.spaces.model.SpaceMember
 class SpaceMembersDiffUtil(
     private val oldList: List<SpaceMember>,
     private val newList: List<SpaceMember>,
-    private val oldNumberOfManagers: Int,
-    private val newNumberOfManagers: Int
+    private val numberOfManagersChanged: Boolean,
+    private val userPermissionsChanged: Boolean
 ) : DiffUtil.Callback() {
     override fun getOldListSize(): Int = oldList.size
 
@@ -45,6 +45,6 @@ class SpaceMembersDiffUtil(
         val newItem = newList[newItemPosition]
 
         return ((oldItem.id == newItem.id) && (oldItem.displayName == newItem.displayName) && (oldItem.roles == newItem.roles)
-                && (oldItem.expirationDateTime == newItem.expirationDateTime) && (oldNumberOfManagers == newNumberOfManagers))
+                && (oldItem.expirationDateTime == newItem.expirationDateTime) && !numberOfManagersChanged && !userPermissionsChanged)
     }
 }

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt

@@ -66,6 +66,7 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
     private var listener: SpaceMemberFragmentListener? = null
     private var canRemoveMembers = false
     private var canEditMembers = false
+    private var numberOfManagers = 1
 
     override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
         _binding = MembersFragmentBinding.inflate(inflater, container, false)
@@ -172,11 +173,11 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
                     is UIResult.Success -> {
                         uiResult.data?.let {
                             if (roles.isNotEmpty()) {
-                                val numberOfManagers = it.members.count { spaceMember ->
+                                numberOfManagers = it.members.count { spaceMember ->
                                     spaceMember.roles.contains(OCRoleType.toString(OCRoleType.CAN_MANAGE)) }
-                                spaceMembersAdapter.setSpaceMembers(it, roles, canRemoveMembers, canEditMembers, numberOfManagers)
                                 spaceMembers = it.members
                                 addMemberRoles = it.roles
+                                spaceMembersAdapter.setSpaceMembers(spaceMembers, roles, canRemoveMembers, canEditMembers, numberOfManagers)
                             }
                         }
                     }
@@ -197,6 +198,7 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
                             binding.addMemberButton.isVisible = DRIVES_CREATE_PERMISSION in spacePermissions
                             canRemoveMembers = DRIVES_DELETE_PERMISSION in spacePermissions
                             canEditMembers = DRIVES_UPDATE_PERMISSION in spacePermissions
+                            spaceMembersAdapter.setSpaceMembers(spaceMembers, roles, canRemoveMembers, canEditMembers, numberOfManagers)
                         }
                     }
                     is UIResult.Loading -> { }