Skip to content

Commit c9113ae

Browse files
committed
feat: add feedback about performance in the warning dialog when automatic uploads are enabled
1 parent 7cc0111 commit c9113ae

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

owncloudApp/src/main/java/com/owncloud/android/presentation/settings/automaticuploads/SettingsPictureUploadsFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ class SettingsPictureUploadsFragment : PreferenceFragmentCompat() {
173173
picturesViewModel.enablePictureUploads(selectedAccount)
174174
showAlertDialog(
175175
title = getString(R.string.common_important),
176-
message = getString(R.string.proper_pics_folder_warning_camera_upload)
176+
message = getString(R.string.proper_pics_folder_warning_camera_upload, getString(R.string.app_name))
177177
)
178178
true
179179
} else {

owncloudApp/src/main/java/com/owncloud/android/presentation/settings/automaticuploads/SettingsVideoUploadsFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ class SettingsVideoUploadsFragment : PreferenceFragmentCompat() {
171171
videosViewModel.enableVideoUploads(selectedAccount)
172172
showAlertDialog(
173173
title = getString(R.string.common_important),
174-
message = getString(R.string.proper_videos_folder_warning_camera_upload)
174+
message = getString(R.string.proper_videos_folder_warning_camera_upload, getString(R.string.app_name))
175175
)
176176
true
177177
} else {

owncloudApp/src/main/res/values/strings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -458,8 +458,8 @@
458458
<string name="confirmation_disable_camera_uploads_title">Confirm</string>
459459
<string name="confirmation_disable_pictures_upload_message">Are you sure you want to disable this feature? The pending pictures will not be uploaded.</string>
460460
<string name="confirmation_disable_videos_upload_message">Are you sure you want to disable this feature? The pending videos will not be uploaded.</string>
461-
<string name="proper_pics_folder_warning_camera_upload">"Please make sure the folder selected is where the camera you are using saves the pictures taken. Otherwise, the feature will not be able to detect your pictures. Keep in mind that pictures will be uploaded in at least 15 minutes after taking them."</string>
462-
<string name="proper_videos_folder_warning_camera_upload">"Please make sure the folder selected is where the camera you are using saves the videos recorded. Otherwise, the feature will not be able to detect your videos. Keep in mind that videos will be uploaded in at least 15 minutes after recording them."</string>
461+
<string name="proper_pics_folder_warning_camera_upload">Please make sure the folder selected is where the camera you are using saves the pictures taken. Otherwise, the feature will not be able to detect your pictures. Keep in mind that pictures will be uploaded in at least 15 minutes after taking them. For a better performance, make sure in your device settings that %1$s is allowed to run in background.</string>
462+
<string name="proper_videos_folder_warning_camera_upload">Please make sure the folder selected is where the camera you are using saves the videos recorded. Otherwise, the feature will not be able to detect your videos. Keep in mind that videos will be uploaded in at least 15 minutes after recording them. For a better performance, make sure in your device settings that %1$s is allowed to run in background.</string>
463463
<string name="conflict_title">File in conflict</string>
464464
<string name="conflict_description">There is a conflict in file %1$s, tap to solve it.</string>
465465
<string name="conflict_message">Which files do you want to keep? If you select both versions, the local file will have a number added to its name.</string>

0 commit comments

Comments
 (0)