refactor: remove unnecessary roles loading

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareFragment.kt

@@ -116,32 +116,12 @@ class GraphShareFragment : Fragment(), GraphSharesAdapter.GraphSharesAdapterList
     }
 
     private fun subscribeToViewModels() {
-        observeRoles()
         observeShares()
         observeSpacePermissions()
         observeAddShareResult()
         observeEditShareResult()
     }
 
-    private fun observeRoles() {
-        collectLatestLifecycleFlow(graphShareViewModel.roles) { event ->
-            event?.let {
-                when (val uiResult = event.peekContent()) {
-                    is UIResult.Success -> {
-                        uiResult.data?.let {
-                            graphShareViewModel.getGraphShares()
-                        }
-                    }
-                    is UIResult.Loading -> { }
-                    is UIResult.Error -> {
-                        showErrorInSnackbar(R.string.share_sync_failed, uiResult.error)
-                        Timber.e(uiResult.error, "Failed to retrieve platform roles")
-                    }
-                }
-            }
-        }
-    }
-
     private fun observeShares() {
         collectLatestLifecycleFlow(graphShareViewModel.shares) { event ->
             event?.let {

owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareViewModel.kt

@@ -30,7 +30,6 @@ import com.owncloud.android.domain.files.model.OCFile
 import com.owncloud.android.domain.members.model.OCMember
 import com.owncloud.android.domain.members.usecases.SearchMembersUseCase
 import com.owncloud.android.domain.roles.model.OCRole
-import com.owncloud.android.domain.roles.usecases.GetRolesAsyncUseCase
 import com.owncloud.android.domain.sharing.shares.usecases.AddGraphShareAsyncUseCase
 import com.owncloud.android.domain.sharing.shares.usecases.EditGraphShareAsyncUseCase
 import com.owncloud.android.domain.sharing.shares.usecases.GetGraphSharesAsyncUseCase
@@ -53,7 +52,6 @@ import kotlinx.coroutines.launch
 class GraphShareViewModel(
     private val addGraphShareAsyncUseCase: AddGraphShareAsyncUseCase,
     private val editGraphShareAsyncUseCase: EditGraphShareAsyncUseCase,
-    private val getRolesAsyncUseCase: GetRolesAsyncUseCase,
     private val getGraphSharesAsyncUseCase: GetGraphSharesAsyncUseCase,
     private val getStoredCapabilitiesUseCase: GetStoredCapabilitiesUseCase,
     private val searchMembersUseCase: SearchMembersUseCase,
@@ -64,9 +62,6 @@ class GraphShareViewModel(
     private val coroutineDispatcherProvider: CoroutinesDispatcherProvider,
 ) : ViewModel() {
 
-    private val _roles = MutableStateFlow<Event<UIResult<List<OCRole>>>?>(null)
-    val roles: StateFlow<Event<UIResult<List<OCRole>>>?> = _roles
-
     private val _shares = MutableStateFlow<Event<UIResult<OCPermissions>>?>(null)
     val shares: StateFlow<Event<UIResult<OCPermissions>>?> = _shares
 
@@ -92,12 +87,6 @@ class GraphShareViewModel(
     val spacePermissions: StateFlow<Event<UIResult<List<String>>>?> = _spacePermissions
 
     init {
-        runUseCaseWithResult(
-            coroutineDispatcher = coroutineDispatcherProvider.io,
-            flow = _roles,
-            useCase = getRolesAsyncUseCase,
-            useCaseParams = GetRolesAsyncUseCase.Params(accountName = accountName),
-        )
         runUseCaseWithResult(
             coroutineDispatcher = coroutineDispatcherProvider.io,
             showLoading = false,
@@ -108,6 +97,7 @@ class GraphShareViewModel(
         viewModelScope.launch(coroutineDispatcherProvider.io) {
             capabilities = getStoredCapabilitiesUseCase(GetStoredCapabilitiesUseCase.Params(accountName))
         }
+        getGraphShares()
         getSpacePermissions()
     }