Merge pull request #4765 from owncloud/fix/permission_to_list_members

[FIX] Permission to list members

Author: jesmrec

CHANGELOG.md

@@ -81,7 +81,9 @@ ownCloud admins and users.
    available).
 
    https://github.com/owncloud/android/issues/4612
+   https://github.com/owncloud/android/issues/4763
    https://github.com/owncloud/android/pull/4728
+   https://github.com/owncloud/android/pull/4765
 
 * Enhancement - Set emoji as space image: [#4707](https://github.com/owncloud/android/issues/4707)
 

changelog/unreleased/4728

@@ -4,4 +4,6 @@ A new option to view all members of a space has been added to the bottom sheet,
 This new option opens a new view that shows information like member names, roles, and expiration dates (if available).
 
 https://github.com/owncloud/android/issues/4612
+https://github.com/owncloud/android/issues/4763
 https://github.com/owncloud/android/pull/4728
+https://github.com/owncloud/android/pull/4765

owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/usecases/FilterSpaceMenuOptionsUseCase.kt

@@ -45,7 +45,9 @@ class FilterSpaceMenuOptionsUseCase(
 
         val editImagePermission = hasSpacePermission(spacePermissionsResult, DRIVES_MANAGE_PERMISSION)
 
-        if (spacePermissionsResult is UseCaseResult.Success) {
+        val membersPermission = hasSpacePermission(spacePermissionsResult, DRIVES_READ_PERMISSION)
+
+        if (membersPermission) {
             optionsToShow.add(SpaceMenuOption.MEMBERS)
         }
 
@@ -85,6 +87,7 @@ class FilterSpaceMenuOptionsUseCase(
     companion object {
         private const val DRIVES_MANAGE_PERMISSION = "libre.graph/driveItem/permissions/update"
         private const val DRIVES_DELETE_PERMISSION = "libre.graph/driveItem/permissions/delete"
+        private const val DRIVES_READ_PERMISSION = "libre.graph/driveItem/permissions/read"
         private const val DRIVES_MANAGER_ROLE = "manager"
     }
 }