Skip to content

Commit 010bc3a

Browse files
committed
feat: add members option in bottom sheet dialog
1 parent 020567f commit 010bc3a

5 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎owncloudApp/src/main/java/com/owncloud/android/extensions/SpaceMenuOptionExt.kt‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ fun SpaceMenuOption.toStringResId() =
3030
SpaceMenuOption.DISABLE -> R.string.disable_space
3131
SpaceMenuOption.ENABLE -> R.string.enable_space
3232
SpaceMenuOption.DELETE -> R.string.delete_space
33+
SpaceMenuOption.MEMBERS -> R.string.space_members
3334
}
3435

3536
fun SpaceMenuOption.toDrawableResId() =
@@ -39,4 +40,5 @@ fun SpaceMenuOption.toDrawableResId() =
3940
SpaceMenuOption.DISABLE -> R.drawable.ic_disable_space
4041
SpaceMenuOption.ENABLE -> R.drawable.ic_enable_space
4142
SpaceMenuOption.DELETE -> R.drawable.ic_action_delete_white
43+
SpaceMenuOption.MEMBERS -> R.drawable.ic_share_generic_white
4244
}

‎owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -444,6 +444,7 @@ class SpacesListFragment :
444444
}
445445
editSpaceImageLauncher.launch(action)
446446
}
447+
SpaceMenuOption.MEMBERS -> { }
447448
}
448449
}
449450
}

‎owncloudApp/src/main/res/values/strings.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -872,6 +872,7 @@
872872
<string name="delete_space_dialog_message">If you delete the selected space, it can no longer be accessed and files will be deleted from the server.</string>
873873
<string name="delete_space_correctly">Space deleted correctly</string>
874874
<string name="delete_space_failed">Space could not be deleted</string>
875+
<string name="space_members">Members</string>
875876

876877
<string name="feedback_dialog_get_in_contact_description"><![CDATA[ Ask for help in our <a href=\"%1$s\"><b>forum</b></a> or contribute in our <a href=\"%2$s\"><b>GitHub repo</b></a>]]></string>
877878

‎owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/model/SpaceMenuOption.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@
2121
package com.owncloud.android.domain.spaces.model
2222

2323
enum class SpaceMenuOption {
24-
EDIT, EDIT_IMAGE, DISABLE, ENABLE, DELETE
24+
EDIT, EDIT_IMAGE, DISABLE, ENABLE, DELETE, MEMBERS
2525
}

‎owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/usecases/FilterSpaceMenuOptionsUseCase.kt‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ class FilterSpaceMenuOptionsUseCase(
4545

4646
val editImagePermission = hasSpacePermission(spacePermissionsResult, DRIVES_MANAGE_PERMISSION)
4747

48+
optionsToShow.add(SpaceMenuOption.MEMBERS)
49+
4850
if (editPermission || isSpaceManager) {
4951
optionsToShow.add(SpaceMenuOption.EDIT)
5052
}

0 commit comments

Comments
 (0)