fix(manager-react-components): correct eslint naming convention

aboungnaseng-ovhcloud · aboungnaseng-ovhcloud · commit af9a387cb686 · 2025-07-17T22:48:27.000+02:00
ref: #MANAGER-18712

Signed-off-by: Alex Boungnaseng &lt;alex.boungnaseng.ext@corp.ovh.com&gt;
diff --git a/packages/manager-react-components/src/components/Link/Link.component.tsx b/packages/manager-react-components/src/components/Link/Link.component.tsx
@@ -9,15 +9,15 @@ import {
   TOOLTIP_POSITION,
 } from '@ovhcloud/ods-react';
 import { useTranslation } from 'react-i18next';
-import { LINK_TYPE, LinkProps, LinkIconsProps } from './Link.props';
+import { LinkType, LinkProps, LinkIconsProps } from './Link.props';
 import { useAuthorizationIam } from '../../hooks';
 
 const LinkIcons: React.FC<LinkIconsProps> = ({ type, children }) => (
   <>
-    {type === LINK_TYPE.back && <Icon name="arrow-left" />}
+    {type === LinkType.back && <Icon name="arrow-left" />}
     {children}
-    {type === LINK_TYPE.external && <Icon name="external-link" />}
-    {type === LINK_TYPE.next && <Icon name="arrow-right" />}
+    {type === LinkType.external && <Icon name="external-link" />}
+    {type === LinkType.next && <Icon name="arrow-right" />}
   </>
 );
 
diff --git a/packages/manager-react-components/src/components/Link/Link.props.ts b/packages/manager-react-components/src/components/Link/Link.props.ts
@@ -1,7 +1,7 @@
 import React, { DOMAttributes } from 'react';
 import { LinkProp } from '@ovhcloud/ods-react';
 
-export enum LINK_TYPE {
+export enum LinkType {
   back = 'back',
   next = 'next',
   external = 'external',
@@ -15,7 +15,7 @@ export interface LinkProps extends LinkProp, DOMAttributes<HTMLAnchorElement> {
   href?: string;
   rel?: string;
   target?: string;
-  type?: LINK_TYPE;
+  type?: LinkType;
   // Iam trigger
   iamActions?: string[];
   urn?: string;
@@ -25,6 +25,6 @@ export interface LinkProps extends LinkProp, DOMAttributes<HTMLAnchorElement> {
 }
 
 export interface LinkIconsProps {
-  type?: LINK_TYPE;
+  type?: LinkType;
   children: React.ReactNode;
 }
diff --git a/packages/manager-react-components/src/components/Link/__tests__/Link.snapshot.test.tsx b/packages/manager-react-components/src/components/Link/__tests__/Link.snapshot.test.tsx
@@ -1,5 +1,5 @@
 import { Link } from '../Link.component';
-import { LINK_TYPE } from '../Link.props';
+import { LinkType } from '../Link.props';
 import { render } from '../../../utils/test.provider';
 
 describe('Link component', () => {
@@ -16,7 +16,7 @@ describe('Link component', () => {
     const props = {
       children: 'Back to the list',
       href: 'https://www.example.com',
-      type: LINK_TYPE.back,
+      type: LinkType.back,
     };
     const { asFragment } = render(<Link {...props} />);
     expect(asFragment()).toMatchSnapshot();
@@ -26,7 +26,7 @@ describe('Link component', () => {
     const props = {
       children: 'Next Page',
       href: 'https://www.example.com',
-      type: LINK_TYPE.next,
+      type: LinkType.next,
     };
     const { asFragment } = render(<Link {...props} />);
     expect(asFragment()).toMatchSnapshot();
@@ -37,7 +37,7 @@ describe('Link component', () => {
       href: 'https://www.ovhcloud.com/',
       target: '_blank',
       children: 'External Page',
-      type: LINK_TYPE.external,
+      type: LinkType.external,
     };
 
     const { asFragment } = render(<Link {...props} />);
diff --git a/packages/manager-react-components/src/components/Link/__tests__/Link.spec.tsx b/packages/manager-react-components/src/components/Link/__tests__/Link.spec.tsx
@@ -2,7 +2,7 @@ import AxiosMockAdapter from 'axios-mock-adapter';
 import { screen, waitFor } from '@testing-library/react';
 import apiClient from '@ovh-ux/manager-core-api';
 import { Link } from '../Link.component';
-import { LINK_TYPE } from '../Link.props';
+import { LinkType } from '../Link.props';
 import { render } from '../../../utils/test.provider';
 
 const PROPS_LINK = {
@@ -26,7 +26,7 @@ describe('Link component', () => {
     const props = {
       children: 'Back to the list',
       href: 'https://www.example.com',
-      type: LINK_TYPE.back,
+      type: LinkType.back,
     };
     render(<Link {...props} />);
     const linkElement = screen.getByText('Back to the list');
@@ -43,7 +43,7 @@ describe('Link component', () => {
     const props = {
       children: 'Next Page',
       href: 'https://www.example.com',
-      type: LINK_TYPE.next,
+      type: LinkType.next,
     };
     render(<Link {...props} />);
     const linkElement = screen.getByText('Next Page');
@@ -61,7 +61,7 @@ describe('Link component', () => {
       href: 'https://www.ovhcloud.com/',
       target: '_blank',
       children: 'External Page',
-      type: LINK_TYPE.external,
+      type: LinkType.external,
     };
 
     render(<Link {...props} />);
diff --git a/packages/manager-react-components/src/components/Link/index.ts b/packages/manager-react-components/src/components/Link/index.ts
@@ -1,3 +1,3 @@
 export { Link } from './Link.component';
 export type { LinkProps } from './Link.props';
-export { LINK_TYPE } from './Link.props';
+export { LinkType } from './Link.props';
diff --git a/packages/manager-react-components/src/components/navigation/card/card.component.tsx b/packages/manager-react-components/src/components/navigation/card/card.component.tsx
@@ -2,7 +2,7 @@ import React from 'react';
 import { useTranslation } from 'react-i18next';
 
 import { OdsBadge, OdsCard } from '@ovhcloud/ods-components/react';
-import { LINK_TYPE, Link } from '../../Link';
+import { LinkType, Link } from '../../Link';
 import './translations/translations';
 
 export interface IBadge {
@@ -89,7 +89,7 @@ export const Card: React.FC<CardProps> = ({
             <Link
               tab-index="-1"
               label={hrefLabel ?? t('see_more_label')}
-              type={isExternalHref ? LINK_TYPE.external : LINK_TYPE.next}
+              type={isExternalHref ? LinkType.external : LinkType.next}
             />
           </div>
         </div>
diff --git a/packages/manager-react-components/src/components/navigation/menus/changelog/changelog.component.tsx b/packages/manager-react-components/src/components/navigation/menus/changelog/changelog.component.tsx
@@ -7,7 +7,7 @@ import {
 import { OdsPopover, OdsButton } from '@ovhcloud/ods-components/react';
 import { useTranslation } from 'react-i18next';
 import { useOvhTracking } from '@ovh-ux/manager-react-shell-client';
-import { Link, LINK_TYPE } from '../../../Link';
+import { Link, LinkType } from '../../../Link';
 import '../translations/translation';
 
 export interface ChangelogLinks {
@@ -54,8 +54,8 @@ export const ChangelogButton: React.FC<ChangelogButtonProps> = ({
             <Link
               href={value}
               target="_blank"
-              type={LINK_TYPE.external}
-              rel={LINK_TYPE.external}
+              type={LinkType.external}
+              rel={LinkType.external}
               label={t(`mrc_changelog_${key}`)}
               onClick={() =>
                 trackClick({
diff --git a/packages/manager-react-components/src/components/navigation/menus/guide/guide.component.tsx b/packages/manager-react-components/src/components/navigation/menus/guide/guide.component.tsx
@@ -7,7 +7,7 @@ import {
 } from '@ovhcloud/ods-components';
 import { OdsPopover, OdsButton } from '@ovhcloud/ods-components/react';
 import { useTranslation } from 'react-i18next';
-import { Link, LinkProps, LINK_TYPE } from '../../../Link';
+import { Link, LinkProps, LinkType } from '../../../Link';
 import '../translations/translation';
 
 export interface GuideItem extends Omit<LinkProps, 'id'> {
@@ -53,7 +53,7 @@ export const GuideButton: React.FC<GuideButtonProps> = ({
           {items.map(({ id, onClick, ...rest }) => (
             <Link
               key={id}
-              type={LINK_TYPE.external}
+              type={LinkType.external}
               onClick={onClick}
               {...rest}
             />
diff --git a/packages/manager-react-components/src/components/order/OrderSummary.component.tsx b/packages/manager-react-components/src/components/order/OrderSummary.component.tsx
@@ -7,7 +7,7 @@ import { OdsButton, OdsText } from '@ovhcloud/ods-components/react';
 import { Trans, useTranslation } from 'react-i18next';
 import React, { useEffect } from 'react';
 import { useOrderContext } from './Order.context';
-import { Link, LINK_TYPE } from '../Link';
+import { Link, LinkType } from '../Link';
 
 export type TOrderSummary = {
   onFinish: () => void;
@@ -54,7 +54,7 @@ export const OrderSummary: React.FC<TOrderSummary> = ({
             components={{
               ExternalLink: (
                 <Link
-                  type={LINK_TYPE.external}
+                  type={LinkType.external}
                   target="_blank"
                   href={orderLink}
                   data-testid="order-summary-link"
diff --git a/packages/manager-react-components/src/components/price/Price.component.tsx b/packages/manager-react-components/src/components/price/Price.component.tsx
@@ -15,7 +15,7 @@ import {
 } from './Price.utils';
 import './translations';
 
-import { PriceText, PRICE_TEXT_PRESET } from './price-text';
+import { PriceText, PriceTextPreset } from './price-text';
 
 export function Price({
   value,
@@ -74,7 +74,7 @@ export function Price({
           <PriceText
             price={priceWithTax}
             label={t('price_ttc_label')}
-            preset={PRICE_TEXT_PRESET.WITH_TAX}
+            preset={PriceTextPreset.WITH_TAX}
           />
         </>
       ),
@@ -117,7 +117,7 @@ export function Price({
           <PriceText
             price={priceWithTax}
             label={t('price_gst_incl_label')}
-            preset={PRICE_TEXT_PRESET.WITH_TAX}
+            preset={PriceTextPreset.WITH_TAX}
           />
         </>
       ),
diff --git a/packages/manager-react-components/src/components/price/__tests__/Price.spec.tsx b/packages/manager-react-components/src/components/price/__tests__/Price.spec.tsx
@@ -18,7 +18,7 @@ vitest.mock('../price-text', async () => {
     intervalUnitText = '',
   }: any) => <span>{`${price} ${label} ${intervalUnitText} `}</span>;
   return {
-    PRICE_TEXT_PRESET: {
+    PriceTextPreset: {
       WITH_TAX: 'with-tax',
     },
     PriceText,
diff --git a/packages/manager-react-components/src/components/price/price-text/PriceText.component.tsx b/packages/manager-react-components/src/components/price/price-text/PriceText.component.tsx
@@ -1,10 +1,10 @@
 import React from 'react';
 import clsx from 'clsx';
 import { Text, TEXT_PRESET } from '@ovhcloud/ods-react';
-import { PriceTextProps, PRICE_TEXT_PRESET } from './PriceText.props';
+import { PriceTextProps, PriceTextPreset } from './PriceText.props';
 
 export const PriceText: React.FC<PriceTextProps> = ({
-  preset = PRICE_TEXT_PRESET.BASE,
+  preset = PriceTextPreset.BASE,
   price,
   intervalUnitText,
   label,
@@ -13,28 +13,28 @@ export const PriceText: React.FC<PriceTextProps> = ({
     preset={TEXT_PRESET.span}
     className={clsx(
       'font-semibold',
-      preset === PRICE_TEXT_PRESET.BASE
+      preset === PriceTextPreset.BASE
         ? 'text-[--ods-color-text] text-[16px] leading-[20px]'
         : 'text-[--ods-color-neutral-500] text-[14px] leading-[18px]',
     )}
   >
-    {preset === PRICE_TEXT_PRESET.WITH_TAX && '('}
+    {preset === PriceTextPreset.WITH_TAX && '('}
     <Text preset={TEXT_PRESET.span} className="mr-1">
       {price}
     </Text>
     {label && (
       <Text
         preset={TEXT_PRESET.span}
-        className={clsx(preset === PRICE_TEXT_PRESET.BASE && 'mr-1')}
+        className={clsx(preset === PriceTextPreset.BASE && 'mr-1')}
       >
         {label}
       </Text>
     )}
-    {intervalUnitText && preset === PRICE_TEXT_PRESET.BASE && (
+    {intervalUnitText && preset === PriceTextPreset.BASE && (
       <Text preset={TEXT_PRESET.span} className="mr-1">
         {intervalUnitText}
       </Text>
     )}
-    {preset === PRICE_TEXT_PRESET.WITH_TAX && ')'}
+    {preset === PriceTextPreset.WITH_TAX && ')'}
   </Text>
 );
diff --git a/packages/manager-react-components/src/components/price/price-text/PriceText.props.ts b/packages/manager-react-components/src/components/price/price-text/PriceText.props.ts
@@ -1,10 +1,10 @@
-export enum PRICE_TEXT_PRESET {
+export enum PriceTextPreset {
   BASE = 'base_price',
   WITH_TAX = 'price_including_tax',
 }
 
 export type PriceTextProps = {
-  preset?: PRICE_TEXT_PRESET;
+  preset?: PriceTextPreset;
   price: string;
   label?: string;
   intervalUnitText?: string;
diff --git a/packages/manager-react-components/src/components/price/price-text/__tests__/PriceText.spec.tsx b/packages/manager-react-components/src/components/price/price-text/__tests__/PriceText.spec.tsx
@@ -1,7 +1,7 @@
 import { describe, it, expect } from 'vitest';
 import { render, screen } from '@testing-library/react';
 import { PriceText } from '../PriceText.component';
-import { PRICE_TEXT_PRESET } from '../PriceText.props';
+import { PriceTextPreset } from '../PriceText.props';
 
 describe('PriceText Component', () => {
   const defaultProps = {
@@ -20,7 +20,7 @@ describe('PriceText Component', () => {
   });
 
   it('should render price with WITH_TAX preset', () => {
-    render(<PriceText {...defaultProps} preset={PRICE_TEXT_PRESET.WITH_TAX} />);
+    render(<PriceText {...defaultProps} preset={PriceTextPreset.WITH_TAX} />);
     const span = screen.getByText('€9.99').parentElement;
 
     expect(screen.getByText('(', { exact: false })).toBeInTheDocument();
@@ -43,7 +43,7 @@ describe('PriceText Component', () => {
       <PriceText
         {...defaultProps}
         label="incl. tax"
-        preset={PRICE_TEXT_PRESET.WITH_TAX}
+        preset={PriceTextPreset.WITH_TAX}
       />,
     );
     expect(screen.getByText('incl. tax')).toBeInTheDocument();
@@ -62,7 +62,7 @@ describe('PriceText Component', () => {
       <PriceText
         {...defaultProps}
         intervalUnitText="/mo"
-        preset={PRICE_TEXT_PRESET.WITH_TAX}
+        preset={PriceTextPreset.WITH_TAX}
       />,
     );
     expect(screen.queryByText('/mo')).not.toBeInTheDocument();
@@ -80,7 +80,7 @@ describe('PriceText Component', () => {
     render(
       <PriceText
         {...defaultProps}
-        preset={PRICE_TEXT_PRESET.WITH_TAX}
+        preset={PriceTextPreset.WITH_TAX}
         label="incl. VAT"
         intervalUnitText="/mo"
       />,
diff --git a/packages/manager-react-components/src/components/price/price-text/index.ts b/packages/manager-react-components/src/components/price/price-text/index.ts
@@ -1,3 +1,3 @@
 export { PriceText } from './PriceText.component';
 
-export { PRICE_TEXT_PRESET } from './PriceText.props';
+export { PriceTextPreset } from './PriceText.props';
diff --git a/packages/manager-react-components/src/components/templates/base/base.component.tsx b/packages/manager-react-components/src/components/templates/base/base.component.tsx
@@ -1,7 +1,7 @@
 import React from 'react';
 import { Headers, HeadersProps } from './headers';
 import { OdsText } from '@ovhcloud/ods-components/react';
-import { LINK_TYPE, Link } from '../../Link';
+import { LinkType, Link } from '../../Link';
 import { Subtitle } from '../../typography';
 import { PageLayout } from '../layout/layout.component';
 
@@ -43,7 +43,7 @@ export const BaseLayout = ({
         <Link
           data-testid="manager-back-link"
           onClick={onClickReturn}
-          type={LINK_TYPE.back}
+          type={LinkType.back}
           target="_self"
           href={hrefPrevious}
         >
diff --git a/packages/manager-wiki/stories/manager-react-components/components/Dashboard/dashboard.mdx b/packages/manager-wiki/stories/manager-react-components/components/Dashboard/dashboard.mdx
@@ -1,7 +1,7 @@
 import { Meta } from '@storybook/blocks';
 import { OdsText } from '@ovhcloud/ods-components/react';
 import { ODS_TEXT_PRESET } from '@ovhcloud/ods-components';
-import { LINK_TYPE, Title } from '@ovh-ux/manager-react-components';
+import { LinkType, Title } from '@ovh-ux/manager-react-components';
 
 <Meta
   title="Manager React Components/Templates/Dashboard/Documentation"
diff --git a/packages/manager-wiki/stories/manager-react-components/components/Link/link.stories.tsx b/packages/manager-wiki/stories/manager-react-components/components/Link/link.stories.tsx
@@ -1,27 +1,27 @@
 import React from 'react';
 import { Meta } from '@storybook/react';
-import { Link, LinkProps, LINK_TYPE } from '@ovh-ux/manager-react-components';
+import { Link, LinkProps, LinkType } from '@ovh-ux/manager-react-components';
 import { IAM_ACTIONS, IAM_URNS } from '../../../../utils/iam.constants';
 
 const backLink: LinkProps = {
   children: 'Back to the list',
   href: 'https://www.ovhcloud.com',
   target: '_blank',
-  type: LINK_TYPE.back,
+  type: LinkType.back,
 };
 
 const nextLink: LinkProps = {
   href: 'https://www.ovhcloud.com/',
   target: '_blank',
   children: 'Next Page',
-  type: LINK_TYPE.next,
+  type: LinkType.next,
 };
 
 const externalLink: LinkProps = {
   href: 'https://www.ovhcloud.com/',
   target: '_blank',
   children: 'External Page',
-  type: LINK_TYPE.external,
+  type: LinkType.external,
 };
 
 const iamLinkWithAuthorization: LinkProps = {
diff --git a/packages/manager-wiki/stories/manager-react-components/whatsnew/1.25-to-1.26.0.mdx b/packages/manager-wiki/stories/manager-react-components/whatsnew/1.25-to-1.26.0.mdx
diff --git a/packages/manager-wiki/stories/manager-react-components/whatsnew/1.x.x-to-2.x.0.mdx b/packages/manager-wiki/stories/manager-react-components/whatsnew/1.x.x-to-2.x.0.mdx
