feat: implement wildcard resolution into the action #93
Conversation
bun install is rqeuired for patches
bun install is rqeuired for patches
| token: | ||
| required: false | ||
| default: ${{ github.token }} | ||
| description: "Personal access token (PAT) used to fetch tags from oven-sh/bun repository" |
There was a problem hiding this comment.
It's more to access api.github.com with the per token rate limit instead of the per IP one. The documentation should mention that is recommended for user using wildcard or range version.
| `https://api.github.com/repos/oven-sh/bun/actions/runs/${run.id}/artifacts`, | ||
| { | ||
| headers: { | ||
| "Authorization": `Bearer ${options.token}`, |
There was a problem hiding this comment.
What if the token is not defined in the configuration? The headers field add could be make conditional
|
Thank you for this, but I think we should fix the endpoint instead of changing the code in the setup action. It’s best to keep the action as small as possible. |
I don't want to be rude but I've been requesting a fix in our private staff Discord channel for a while with no response. People are asking for it in the issue #37 without any response from the core team. Since this issue is affecting people, I decided to finally resolve this issue even though I'm on vacation. You just closed this pull request and only said that it's better to fix the API, but when can we expect this issue to be resolved? I transferred this action to the oven-sh organisation because you asked for it. I'm happy to have been able to do so, but the API problems are making it harder for me to maintain setup-bun action. |
Resolves #37
https://bun.sh/downloadis not used anymore