WHIP: X509 cert serial number should be positive. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since Go1.23, Go DTLS server may fail the FFmpeg request, for it verify the serial number: if serial.Sign() == -1 {
if x509negativeserial.Value() != "1" {
return nil, errors.New("x509: negative serial number") |
winlinvip
force-pushed
the
bugfix/cert-serial-number
branch
18 times, most recently
from
3f81f6b to
1269248
Compare
winlinvip
force-pushed
the
workflows
branch
4 times, most recently
from
3294e09 to
4aa17ba
Compare
winlinvip
force-pushed
the
bugfix/cert-serial-number
branch
2 times, most recently
from
4192d9a to
ab60ac1
Compare
The patch is still generated by git config author.
refer to https://www.ffmpeg.org/developer.html#Submitting-patches-1 add header "X-Unsent: 1" add email recipients Signed-off-by: Jack Lau <[email protected]>
All files in the .github directory pertain to CI/CD and should be ignored; they should not be included in the patch.
This PR refer to ossrs#39 and ossrs#38 --------- Signed-off-by: Jack Lau <[email protected]>
ghost
force-pushed
the
bugfix/cert-serial-number
branch
from
ab60ac1 to
16b991e
Compare
See RFC5280 4.1.2.2 Signed-off-by: Jack Lau <[email protected]>
ghost
force-pushed
the
bugfix/cert-serial-number
branch
from
16b991e to
88fd0e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC5280 4.1.2.2, The serial number MUST be a positive integer assigned by the CA to each certificate.