-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: CodeQL default config not identified #3451
Comments
I believe this is because they don't merge PRs. And Scorecard currently looks for SAST tools before merging. some discussion here: |
Hmm, it can be the case then. If I find any similar scenario that do merge PRs, I can bring here. Otherwise, I believe this can be solved for now. |
Actually, I have one question: why it need to be merged to the SAST run to be considered? The Security Dashboard will be filled with the findings anyway right? and occasionally can be fixed because of that. |
My understanding is it's to find bugs before they're merged, not after. |
Describe the bug
I've run into a scenario where the project was running CodeQL by using the default configuration
Then looking into the runs on Actions, I've noticed it was running CodeQL check on all commits and PRs https://github.com/protocolbuffers/protobuf/actions/workflows/github-code-scanning/codeql
But since there is no config yml file for this action run, the score for the project in SAST check is 0/10
Reproduction steps
Steps to reproduce the behavior:
scorecard --repo=protocolbuffers/protobuf --checks=SAST --show-details
Expected behavior
Since the project is indeed running SAST for all commits, this should be identified.
Additional context
In this specific scenario, it is not running for all available programing languages, but I believe Scorecard is not considering this to grant a score currently. In this case, I'd say protocolbuffers/protobuf should score 10/10 in SAST.
The text was updated successfully, but these errors were encountered: