Merged
Conversation
032587a to
c1d0944
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed?
I cleaned up the pilotdatasync-xp11.macos.cpp so that it fully implements the TCP base and changed lines of code that are windows only. Also removed a few UDP lines I had from previous attempts to get a direct connection to imotions.
Changed menson.build so that if the plugin is ran from windows or mac it will change what pilotdatasync it uses instead of being hard coded for windows only. I also did the same thing for build.rs that was hard coded for Windows only.
Added a mac-x86_64.ini this is because X-Plane 11 when using mac plugins requires an intel x86_64
Why was it changed?
For some reason after a winter break the program decided not to work anymore on mac while still working on windows, this isn't a huge problem as the client that this is being built for uses windows. But since I mainly use mac if I wanted this program to fully work for me these changes had to be made aswell as its a great implementation to have it compatible with mac and windows. I think the next step for compatibility is to get it working for linux.
How was it changed?
For the pilotdatasync-xp11.macos.cpp I removed any mention of UDP after thinking that maybe that was the issue with it trying to compile tcp and udp. I do want to preface that some AI was used to help organize files and explain error codes that I was getting### What was changed?
I cleaned up the pilotdatasync-xp11.macos.cpp so that it fully implements the TCP base and changed lines of code that are windows only. Also removed a few UDP lines I had from previous attempts to get a direct connection to imotions.
Changed menson.build so that if the plugin is ran from windows or mac it will change what pilotdatasync it uses instead of being hard coded for windows only. I also did the same thing for build.rs that was hard coded for Windows only.
Added a mac-x86_64.ini this is because X-Plane 11 when using mac plugins requires an intel x86_64
Why was it changed?
For some reason after a winter break the program decided not to work anymore on mac while still working on windows, this isn't a huge problem as the client that this is being built for uses windows. But since I mainly use mac if I wanted this program to fully work for me these changes had to be made aswell as its a great implementation to have it compatible with mac and windows. I think the next step for compatibility is to get it working for linux.
How was it changed?
For the pilotdatasync-xp11.macos.cpp I removed any mention of UDP after thinking that maybe that was the issue with it trying to compile tcp and udp. I do want to preface that some AI was used to help organize files and explain error codes that I was getting
Before merging please make sure that xplane still works on windows with these changes :)