Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all plugins to the new KSP-based org.ossreviewtoolkit.plugins.api.Plugin API #9403

Closed
4 tasks done
sschuberth opened this issue Nov 10, 2024 · 3 comments
Closed
4 tasks done

Migrate all plugins to the new KSP-based org.ossreviewtoolkit.plugins.api.Plugin API #9403

sschuberth opened this issue Nov 10, 2024 · 3 comments
Assignees
@mnonnenmacher
Labels
plugin Topics related to ORT plugins tech debt Technical debt that should be addressed

Comments

@sschuberth
Copy link
Member

sschuberth commented Nov 10, 2024 •
edited by mnonnenmacher
Loading

Remaining plugin types to migrate are:
@sschuberth sschuberth added plugin Topics related to ORT plugins tech debt Technical debt that should be addressed labels Nov 10, 2024
@sschuberth sschuberth changed the title Migrate all plugins to the new KSP-based plugin API Migrate all plugins to the new KSP-based org.ossreviewtoolkit.plugins.api.Plugin API Nov 10, 2024
@mnonnenmacher mnonnenmacher mentioned this issue Nov 11, 2024
Closed
8 tasks
@sschuberth sschuberth mentioned this issue Nov 14, 2024
Closed
@mnonnenmacher mnonnenmacher self-assigned this Nov 24, 2024
@mnonnenmacher

This comment has been minimized.

Sign in to view
mnonnenmacher added a commit that referenced this issue Nov 26, 2024
@mnonnenmacher
refactor(commands)!: Migrate command plugins to new plugin API
6877fea 
WIP: This requires support for custom constructor args because the
`CliktCommand` class takes the `name` as a constructor argument.

Relates to #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher mentioned this issue Nov 26, 2024
Merged
mnonnenmacher added a commit that referenced this issue Nov 26, 2024
@mnonnenmacher
refactor(commands)!: Migrate command plugins to new plugin API
5f22e1c 
Migrate the command plugins to the new plugin API.

Relates to #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Nov 26, 2024
@mnonnenmacher
refactor(commands)!: Migrate command plugins to new plugin API
f1a85ce 
Migrate the command plugins to the new plugin API.

Relates to #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Dec 8, 2024
@mnonnenmacher
refactor(commands)!: Migrate command plugins to new plugin API
2e60641 
Migrate the command plugins to the new plugin API.

Relates to #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Dec 8, 2024
@mnonnenmacher
refactor(commands)!: Migrate command plugins to new plugin API
b12f874 
Migrate the command plugins to the new plugin API.

Relates to #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@sschuberth sschuberth mentioned this issue Dec 13, 2024
Open
@mnonnenmacher
Copy link
Member

mnonnenmacher commented Dec 16, 2024 •
edited
Loading

I have now started with the scanner plugin migration.

@sschuberth
Copy link
Member Author

Reminder: Upon finalizing the migration, also org.ossreviewtoolkit.model.config.PluginConfiguration should be replace with org.ossreviewtoolkit.plugins.api.PluginConfig.

sschuberth added a commit that referenced this issue Jan 14, 2025
@sschuberth
refactor(commands)!: Migrate VCS plugins to new plugin API
d4420b4 
Relates to #9403.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 14, 2025
@sschuberth
refactor(commands)!: Migrate VCS plugins to new plugin API
6af795d 
Relates to #9403.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 15, 2025
@sschuberth
refactor(commands)!: Migrate VCS plugins to new plugin API
2ee9448 
Relates to #9403.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 15, 2025
@sschuberth
refactor(commands)!: Migrate VCS plugins to new plugin API
8df4ded 
Relates to #9403.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 15, 2025
@sschuberth
refactor(commands)!: Migrate VCS plugins to new plugin API
87b4c04 
Relates to #9403.

Signed-off-by: Sebastian Schuberth <[email protected]>
mnonnenmacher added a commit that referenced this issue Mar 5, 2025
@mnonnenmacher
feat(analyzer)!: Migrate package managers to new plugin API
c14268d 
As part of this refactoring the `analzyerConfig` argument is moved from
the constructor to the `beforeResolution` and `resolveDependencies`
functions. This was not done in a separate commit because it would have
required a lot of code changes that would have been removed again as
part of the migration.

Resolves #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Mar 6, 2025
@mnonnenmacher
feat(analyzer)!: Migrate package managers to new plugin API
2cb64ac 
As part of this refactoring the `analzyerConfig` argument is moved from
the constructor to the `beforeResolution` and `resolveDependencies`
functions. This was not done in a separate commit because it would have
required a lot of code changes that would have been removed again as
part of the migration.

Resolves #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Mar 6, 2025
@mnonnenmacher
feat(analyzer)!: Migrate package managers to new plugin API
0b59879 
As part of this refactoring the `analzyerConfig` argument is moved from
the constructor to the `beforeResolution` and `resolveDependencies`
functions. This was not done in a separate commit because it would have
required a lot of code changes that would have been removed again as
part of the migration.

Resolves #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Mar 6, 2025
@mnonnenmacher
feat(analyzer)!: Migrate package managers to new plugin API
180da98 
As part of this refactoring the `analzyerConfig` argument is moved from
the constructor to the `beforeResolution` and `resolveDependencies`
functions. This was not done in a separate commit because it would have
required a lot of code changes that would have been removed again as
part of the migration.

Resolves #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Mar 6, 2025
@mnonnenmacher
feat(analyzer)!: Migrate package managers to new plugin API
c542022 
As part of this refactoring the `analzyerConfig` argument is moved from
the constructor to the `beforeResolution` and `resolveDependencies`
functions. This was not done in a separate commit because it would have
required a lot of code changes that would have been removed again as
part of the migration.

Resolves #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Mar 6, 2025
@mnonnenmacher
feat(analyzer)!: Migrate package managers to new plugin API
fcef728 
As part of this refactoring the `analzyerConfig` argument is moved from
the constructor to the `beforeResolution` and `resolveDependencies`
functions. This was not done in a separate commit because it would have
required a lot of code changes that would have been removed again as
part of the migration.

Resolves #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Mar 6, 2025
@mnonnenmacher
feat(analyzer)!: Migrate package managers to new plugin API
f72dd1b 
As part of this refactoring the `analzyerConfig` argument is moved from
the constructor to the `beforeResolution` and `resolveDependencies`
functions. This was not done in a separate commit because it would have
required a lot of code changes that would have been removed again as
part of the migration.

Resolves #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Mar 6, 2025
@mnonnenmacher
feat(analyzer)!: Migrate package managers to new plugin API
ec425c3 
As part of this refactoring the `analzyerConfig` argument is moved from
the constructor to the `beforeResolution` and `resolveDependencies`
functions. This was not done in a separate commit because it would have
required a lot of code changes that would have been removed again as
part of the migration.

Resolves #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit that referenced this issue Mar 6, 2025
@mnonnenmacher
feat(analyzer)!: Migrate package managers to new plugin API
a7357bf 
As part of this refactoring the `analzyerConfig` argument is moved from
the constructor to the `beforeResolution` and `resolveDependencies`
functions. This was not done in a separate commit because it would have
required a lot of code changes that would have been removed again as
part of the migration.

Resolves #9403.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@sschuberth sschuberth mentioned this issue Mar 7, 2025
Merged
mnonnenmacher added a commit that referenced this issue Mar 7, 2025
@mnonnenmacher
refactor(model)!: Replace PluginConfiguration with PluginConfig
42e46c0 
Remove the old `PluginConfiguration` class and replace all usages with
the new `PluginConfig` class [1].

Also add an `orEmpty()` convenience function to simplify some code that
is changed as part of this commit.

[1]: #9403 (comment)

Signed-off-by: Martin Nonnenmacher <[email protected]>
sschuberth pushed a commit that referenced this issue Mar 7, 2025
@mnonnenmacher @sschuberth
refactor(model)!: Replace PluginConfiguration with PluginConfig
66b03c5 
Remove the old `PluginConfiguration` class and replace all usages with
the new `PluginConfig` class [1].

Also add an `orEmpty()` convenience function to simplify some code that
is changed as part of this commit.

[1]: #9403 (comment)

Signed-off-by: Martin Nonnenmacher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnonnenmacher mnonnenmacher

Labels
plugin Topics related to ORT plugins tech debt Technical debt that should be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sschuberth @mnonnenmacher