Split expense with exact amounts not working

[dvdmlln]

Describe the bug
When adding an expense and using exact amount, the input fields always show 0 instead of the actual value.

To Reproduce
Steps to reproduce the behavior:

1. Add an expense
2. Select "Exact"
3. Try to enter an amount

Expected behavior
The entered amount should be displayed

Screenshots

App version
1.5.3

Desktop:

• OS: Windows 11
• Browser Firefox
• Version 143.0.3

Smartphone:

• Device: Pixel 9a
• OS: Android 16
• Browser Chrome/PWA Installed
• Version 140

[Himanshu9271]

Are you not able to edit the input field ?
I tried to recreate this but was not able to, i was able to edit the input fields and save the split.

[dvdmlln]

I was able to edit the input field I think, because the remaining amount changed, but the input field always shows 0. I'll do some more testing later if you are not able to reproduce.

[dvdmlln]

I setup an developer instance and still got the same error. So everything is working for you?
What I've figured out so far: after the onChangeInput event in SplitTypeSection fires, the ParticipantRow Component is called twice. First with the correct share value and after that with an undefined share.
The input event only fires once and the setSplitShare action is called once as well.

[dvdmlln]

Ok, I've figured the problem. You can ignore my comment from before.
The input in the ParticipantRow component is a number type. For SplitType.EXACT the fmtShareText function calls the toUIString function from number utils, which uses Number.toLocaleString. This is fine for locales with a dot as a decimal seperator, but in my case it's a comma, so the value can't be displayed in a number input.

[krokosik]

Ah yes, locale aware formatting has not been implemented yet. It is pretty intricate with all the currency formats, for example JPY uses no decimal points, while the Bahrani currency has 3 fractional digits. Proper formatting would be great to have, but I did not have the time to implement it yet. Contributions are welcome if you need it now.

[dvdmlln]

I created a PR to fix this issue. Since number input only allows a dot as a decimal seperator and also no thousand seperator the toUIString is not really suitable here. Even if I use for example en-US as a locale with a dot as a decimal seperator the input does not work if enter an amount > 1000.

[MasterPi-2124]

Ah yes, locale aware formatting has not been implemented yet. It is pretty intricate with all the currency formats, for example JPY uses no decimal points, while the Bahrani currency has 3 fractional digits. Proper formatting would be great to have, but I did not have the time to implement it yet. Contributions are welcome if you need it now.

@krokosik could you take a look at my PR please? My PR also tempts to fix the issues with that section

[krokosik]

I will when I have the bandwidth. Could you link it to the issue in the meantime?

[krokosik]

The issue should be addressed with #437 PR, which is now released with v1.5.4 along with some other backported fixes. Apologies for the long wait!