Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing due to {{Taginfo entry|*}} in tables: template is a cell #2469

Closed
Famlam opened this issue Mar 7, 2025 · 3 comments
Closed
Labels

Comments

@Famlam
Copy link
Collaborator

Famlam commented Mar 7, 2025

Currently tests for TagWatchFrViPofm.py are failing because of this table row:

|School:FR||school:FR || typo-tag || FR
{{Taginfo entry|School:FR}}

The reason for failing is because FR isn't detected is because the {{Taginfo entry|*}} template is defined as a cell, e.g. it seems to insert something like | 123 (if the taginfo count is 123). Hence, people editing the table omit the (normally) preceeding |.

Probably the safest way to deal with this (assuming we'll never actually need the count of taginfo via this template) is to just replace {{Taginfo entry|*}} by | or || using read_wiki_templates.

@frodrigo
Copy link
Member

frodrigo commented Mar 8, 2025

That a so frequent issue that we need to deal with it on the code ?

Can't we just fix the wiki ?

@Famlam
Copy link
Collaborator Author

Famlam commented Mar 8, 2025

It's a template on the osm wiki. I don't think we can delete the template? The wiki isn't broken, this is the intended behavior of the template (even though I dislike it)

@frodrigo
Copy link
Member

frodrigo commented Mar 8, 2025

Ok, I understand better. So, yes, I also think what you suggest is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants