Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thie regexp of requireRegex cannot match Template literals #2

Open
jawn-ha opened this issue Jul 1, 2021 · 2 comments
Open

thie regexp of requireRegex cannot match Template literals #2

jawn-ha opened this issue Jul 1, 2021 · 2 comments

Comments

@jawn-ha
Copy link

jawn-ha commented Jul 1, 2021

Thanks for your amazing working first
thie regexp of requireRegex cannot match Template literals
I hope you can change requireRegex to /require\s*\(\s*(["'].*?["'])\s*\)/g;
I am badly need this
@jawn-ha
Copy link
Author

jawn-ha commented Jul 1, 2021 

/require\s*\(\s*(["'`].*?["'`])\s*\)/g;

@flyfishzy
Copy link
Member

flyfishzy commented Jul 1, 2021 •
edited
Loading

Could you provide an example for reproduction? If the require has dynamic path, it will cause problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flyfishzy @jawn-ha