Python CloudShellAPISession to support passing keyword args to the urllib3 object

[C1ARKGABLE]

What is the problem?

Currently, users of the CloudShellAPISession and CommonAPISession are not able to interact with the urllib3.PoolManager object.

Why is it a problem?

Accessing urllib3's feature set will reduce your need to write and maintain custom code when handling retries, timeouts, and more.

How do you solve the problem today?

We directly inject values to the urllib3.PoolManager.connection_pool_kw dictionary. This is dirty, but really effective

from cloudshell.api.cloudshell_api import CloudShellAPISession
from urllib3 import Timeout

api = CloudShellAPISession(...)
api._http.connection_pool_kw["timeout"] = Timeout(total=20)

How would you ideally solve the problem?

class CommonAPISession:
    def __init__(self, host, username, password, domain, connection_pool_size=25, **kwargs):
        ...

        self._http = urllib3.PoolManager(num_pools=connection_pool_size, ssl_context=ctx, **kwargs)

and

class CloudShellAPISession(CommonAPISession):
    def __init__(
        self,
        host,
        ...,
        **kwargs
    ):
        CommonAPISession.__init__(self, host, username, password, domain, **kwargs)

How big is the problem (frequency of impact, who is impacted)

For anyone who uses CloudShellAPISession, directly accessing the functionality provided by urllib3 would be great for getting the most out of the tools that already exist. urllib3 is well tested and requires very minimal effort

NOTE: There is already a related idea box

[nahumtimerman]

Thanks Gabe, I think this is a very good suggestion.
I'll add a ticket to our backlog.