You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When I work with a screen, it is often necessary to change the name, description, and actions depending on the state of the object. This usually means some override directly in the query method.
This is not what I would like to see in a method that is responsible for transferring data.
Also, this can introduce some confusion to users, for example, in issue #1277
Describe the solution you'd like
Perhaps it is worth expanding the number of methods that would receive a ready-made data set:
Then there will be fewer actions to be performed in query and do not need to enter class properties. This approach's critical disadvantage is that because the class argument can store any variables, there will be no auto-hints in the IDE.
Additional context
Most likely, this can be done without breaking backward compatibility. Provided, of course, that the user no longer has methods named the same. There is also only one property, $permission, that should be changed into a method without actually getting and executing the query method.
This discussion was converted from issue #1290 on May 21, 2021 19:20.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Is your feature request related to a problem? Please describe.
When I work with a screen, it is often necessary to change the name, description, and actions depending on the state of the object. This usually means some override directly in the
query
method.For example:
This is not what I would like to see in a method that is responsible for transferring data.
Also, this can introduce some confusion to users, for example, in issue #1277
Describe the solution you'd like
Perhaps it is worth expanding the number of methods that would receive a ready-made data set:
Then there will be fewer actions to be performed in
query
and do not need to enter class properties. This approach's critical disadvantage is that because the class argument can store any variables, there will be no auto-hints in the IDE.Additional context
Most likely, this can be done without breaking backward compatibility. Provided, of course, that the user no longer has methods named the same. There is also only one property,
$permission,
that should be changed into a method without actually getting and executing thequery
method.Beta Was this translation helpful? Give feedback.
All reactions