From 5eaa445073ed8e07de29daa1acc22096620aa59f Mon Sep 17 00:00:00 2001
From: Edward Faulkner <edward@eaf4.com>
Date: Sun, 13 Mar 2022 20:58:39 -0400
Subject: [PATCH] Failing test for remoteId on unloaded relationship with data

In https://github.com/orbitjs/ember-orbit/issues/400 @dgeb suggested that even unloaded records should have a type, id, and (if configured) remoteId key when accessed via a relationship that loaded with a `data` property.

These tests demonstrate that that works when the related record is already loaded, but fails when it is not.
---
 tests/integration/model-test.ts | 67 +++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/tests/integration/model-test.ts b/tests/integration/model-test.ts
index f021ea28..9ed00d5c 100644
--- a/tests/integration/model-test.ts
+++ b/tests/integration/model-test.ts
@@ -680,4 +680,71 @@ module('Integration - Model', function (hooks) {
     assert.strictEqual(jupiter.name, 'Jupiter');
     assert.strictEqual(jupiter.hasName, true);
   });
+
+  test('hasOne contains type, id, and remoteId for loaded record', async function (assert) {
+    await store.addRecord<Planet>({
+      type: 'planet',
+      remoteId: '3',
+      name: 'Mars'
+    });
+
+    await store.source.update((t) => {
+      return t.addRecord({
+        type: 'moon',
+        id: '4-1',
+        attributes: {
+          name: 'Phobos'
+        },
+        relationships: {
+          planet: {
+            data: t.$normalizeRecordIdentity({
+              type: 'planet',
+              key: 'remoteId',
+              value: '3'
+            })
+          }
+        }
+      });
+    });
+
+    let phobos = await store.query<Moon>((qb) =>
+      qb.findRecord({
+        type: 'moon',
+        id: '4-1'
+      })
+    );
+    assert.strictEqual(phobos.planet?.type, 'planet', 'has expected type');
+    assert.ok(phobos.planet?.id, 'has an id');
+    assert.strictEqual(phobos.planet?.remoteId, '3', 'has expected remoteId');
+  });
+
+  test('hasOne contains type, id, and remoteId for unloaded record', async function (assert) {
+    await store.source.update((t) => {
+      return t.addRecord({
+        type: 'moon',
+        id: '4-1',
+        attributes: {
+          name: 'Phobos'
+        },
+        relationships: {
+          planet: {
+            data: t.$normalizeRecordIdentity({
+              type: 'planet',
+              key: 'remoteId',
+              value: '3'
+            })
+          }
+        }
+      });
+    });
+    let phobos = await store.query<Moon>((qb) =>
+      qb.findRecord({
+        type: 'moon',
+        id: '4-1'
+      })
+    );
+    assert.strictEqual(phobos.planet?.type, 'planet', 'has expected type');
+    assert.ok(phobos.planet?.id, 'has an id');
+    assert.strictEqual(phobos.planet?.remoteId, '3', 'has expected remoteId');
+  });
 });