Skip to content

Remove duplicate check for existing finalizer #8

@al3xandru

Description

@al3xandru

(Minor) Method AddFinalizers is doing a check if the finalizer is already present before delegating to controllerutil.AddFinalizer. The implementation of controllerutil.AddFinalizer is doing that check too already: https://github.com/kubernetes-sigs/controller-runtime/blob/7ba3e559790c5e3543002a0d9670b4cef3ccf743/pkg/controller/controllerutil/controllerutil.go#L351

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions