Skip to content

Commit 3309929

Browse files
authored
Better support for elasticity operations (#30)
* Modified internal query processing to better support elasticity operations
1 parent 4eaa354 commit 3309929

14 files changed

+624
-288
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
2020

2121
### Changed
2222
- Changed copyrights to 2024
23+
- Modified internal query processing to better support elasticity operations
2324

2425
## 1.4.2 - 2023-09-25
2526

nosqldb/bad_protocol_test.go

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ func (suite *BadProtocolTestSuite) createTableAndIndex() {
115115

116116
// processTestResponse is a custom handleResponse function for the Client.
117117
// It checks error code from the response, does not parse the response content.
118-
func processTestResponse(httpResp *http.Response, req nosqldb.Request, serialVerUsed int16) (nosqldb.Result, error) {
118+
func processTestResponse(httpResp *http.Response, req nosqldb.Request, serialVerUsed int16, queryVerUsed int16) (nosqldb.Result, error) {
119119
data, err := io.ReadAll(httpResp.Body)
120120
httpResp.Body.Close()
121121
if err != nil {
@@ -167,7 +167,8 @@ func seekPos(lengths []int, fieldOff int) (off int) {
167167

168168
func (suite *BadProtocolTestSuite) doBadProtoTest(req nosqldb.Request, data []byte, desc string, expectErrCode nosqlerr.ErrorCode) {
169169
serialVerUsed := suite.bpTestClient.GetSerialVersion()
170-
_, err := suite.bpTestClient.DoExecute(context.Background(), req, data, serialVerUsed)
170+
queryVerUsed := suite.bpTestClient.GetQueryVersion()
171+
_, err := suite.bpTestClient.DoExecute(context.Background(), req, data, serialVerUsed, queryVerUsed)
171172
switch expectErrCode {
172173
case nosqlerr.NoError:
173174
suite.NoErrorf(err, "%q should have succeeded, got error %v", desc, err)
@@ -179,7 +180,8 @@ func (suite *BadProtocolTestSuite) doBadProtoTest(req nosqldb.Request, data []by
179180

180181
func (suite *BadProtocolTestSuite) doBadProtoTest2(req nosqldb.Request, data []byte, desc string, expectErrCode1 nosqlerr.ErrorCode, expectErrCode2 nosqlerr.ErrorCode) {
181182
serialVerUsed := suite.bpTestClient.GetSerialVersion()
182-
_, err := suite.bpTestClient.DoExecute(context.Background(), req, data, serialVerUsed)
183+
queryVerUsed := suite.bpTestClient.GetQueryVersion()
184+
_, err := suite.bpTestClient.DoExecute(context.Background(), req, data, serialVerUsed, queryVerUsed)
183185
suite.Truef((nosqlerr.Is(err, expectErrCode1) || nosqlerr.Is(err, expectErrCode2)),
184186
"%q failed, got error %v, want error %s or %s", desc, err, expectErrCode1, expectErrCode2)
185187
}
@@ -191,7 +193,7 @@ func (suite *BadProtocolTestSuite) TestBadGetRequest() {
191193
Key: suite.key,
192194
}
193195

194-
data, _, err := suite.bpTestClient.ProcessRequest(req)
196+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
195197
suite.Require().NoError(err)
196198
origData := make([]byte, len(data))
197199
copy(origData, data)
@@ -265,7 +267,7 @@ func (suite *BadProtocolTestSuite) TestBadGetIndexesRequest() {
265267
IndexName: suite.index,
266268
}
267269

268-
data, _, err := suite.bpTestClient.ProcessRequest(req)
270+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
269271
suite.Require().NoError(err)
270272
origData := make([]byte, len(data))
271273
copy(origData, data)
@@ -306,7 +308,7 @@ func (suite *BadProtocolTestSuite) TestBadGetTableRequest() {
306308
TableName: suite.table,
307309
}
308310

309-
data, _, err := suite.bpTestClient.ProcessRequest(req)
311+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
310312
suite.Require().NoError(err)
311313
origData := make([]byte, len(data))
312314
copy(origData, data)
@@ -342,7 +344,7 @@ func (suite *BadProtocolTestSuite) TestBadListTablesRequest() {
342344
Namespace: ns,
343345
}
344346

345-
data, _, err := suite.bpTestClient.ProcessRequest(req)
347+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
346348
suite.Require().NoError(err)
347349
origData := make([]byte, len(data))
348350
copy(origData, data)
@@ -393,7 +395,7 @@ func (suite *BadProtocolTestSuite) TestBadListTablesRequest() {
393395
func (suite *BadProtocolTestSuite) TestBadPrepareRequest() {
394396
stmt := "select * from " + suite.table
395397
req := &nosqldb.PrepareRequest{Statement: stmt}
396-
data, _, err := suite.bpTestClient.ProcessRequest(req)
398+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
397399
suite.Require().NoError(err)
398400
origData := make([]byte, len(data))
399401
copy(origData, data)
@@ -501,7 +503,7 @@ func (suite *BadProtocolTestSuite) TestBadQueryRequest() {
501503
2, // VariableValue: INT_TYPE + packed int
502504
}
503505

504-
data, _, err := suite.bpTestClient.ProcessRequest(req)
506+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
505507
suite.Require().NoError(err)
506508
origData := make([]byte, len(data))
507509
copy(origData, data)
@@ -597,7 +599,7 @@ func (suite *BadProtocolTestSuite) TestBadPutRequest() {
597599
ttlLen, // TTL: value(packed long) + unit(byte)
598600
}
599601

600-
data, _, err := suite.bpTestClient.ProcessRequest(req)
602+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
601603
suite.Require().NoError(err)
602604
origData := make([]byte, len(data))
603605
copy(origData, data)
@@ -679,7 +681,7 @@ func (suite *BadProtocolTestSuite) TestBadDeleteRequest() {
679681
0, // MatchVersion: bytes
680682
}
681683

682-
data, _, err := suite.bpTestClient.ProcessRequest(req)
684+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
683685
suite.Require().NoError(err)
684686
origData := make([]byte, len(data))
685687
copy(origData, data)
@@ -736,7 +738,7 @@ func (suite *BadProtocolTestSuite) TestBadWriteMultipleRequest() {
736738
0, // Sub requests: the size does not matter for this test.
737739
}
738740

739-
data, _, err := suite.bpTestClient.ProcessRequest(req)
741+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
740742
suite.Require().NoError(err)
741743
origData := make([]byte, len(data))
742744
copy(origData, data)
@@ -796,7 +798,7 @@ func (suite *BadProtocolTestSuite) TestBadMultiDeleteRequest() {
796798
21, // ContinuationKey: byte array
797799
}
798800

799-
data, _, err := suite.bpTestClient.ProcessRequest(req)
801+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
800802
suite.Require().NoError(err)
801803
origData := make([]byte, len(data))
802804
copy(origData, data)
@@ -872,7 +874,7 @@ func (suite *BadProtocolTestSuite) TestBadTableRequest() {
872874
1, // HasTableName: boolean
873875
}
874876

875-
data, _, err := suite.bpTestClient.ProcessRequest(req)
877+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
876878
suite.Require().NoError(err)
877879
suite.AddToTables(newTable)
878880
origData := make([]byte, len(data))
@@ -932,7 +934,7 @@ func (suite *BadProtocolTestSuite) TestBadSystemRequest() {
932934
stmtLen, // Statement: string
933935
}
934936

935-
data, _, err := suite.bpTestClient.ProcessRequest(req)
937+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
936938
suite.Require().NoError(err)
937939
origData := make([]byte, len(data))
938940
copy(origData, data)
@@ -982,7 +984,7 @@ func (suite *BadProtocolTestSuite) TestBadSystemStatusRequest() {
982984
stmtLen, // Statement: string
983985
}
984986

985-
data, _, err := suite.bpTestClient.ProcessRequest(req)
987+
data, _, _, err := suite.bpTestClient.ProcessRequest(req)
986988
suite.Require().NoError(err)
987989
origData := make([]byte, len(data))
988990
copy(origData, data)

0 commit comments

Comments
 (0)