Skip to content

Commit 9652d9c

Browse files
agrimkmrDzurbmayoor
authored
[AQUA] handling Model Deployment list for model group deployment type (#1247)
Co-authored-by: Dmitrii Cherkasov <[email protected]> Co-authored-by: Mayoor Rao <[email protected]>
1 parent 3dd0dba commit 9652d9c

File tree

2 files changed

+22
-11
lines changed

2 files changed

+22
-11
lines changed

ads/aqua/constants.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@
5656
MODEL_BY_REFERENCE_OSS_PATH_KEY = "artifact_location"
5757

5858
AQUA_CHAT_TEMPLATE_METADATA_KEY = "chat_template"
59+
UNKNOWN_ENUM_VALUE = "UNKNOWN_ENUM_VALUE"
60+
MODEL_GROUP = "MODEL_GROUP"
61+
SINGLE_MODEL_FLEX = "SINGLE_MODEL_FLEX"
5962

6063
CONSOLE_LINK_RESOURCE_TYPE_MAPPING = {
6164
"datasciencemodel": "models",

ads/aqua/modeldeployment/deployment.py

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,11 @@
4444
AQUA_MODEL_TYPE_SERVICE,
4545
AQUA_MULTI_MODEL_CONFIG,
4646
MODEL_BY_REFERENCE_OSS_PATH_KEY,
47+
MODEL_GROUP,
4748
MODEL_NAME_DELIMITER,
49+
SINGLE_MODEL_FLEX,
4850
UNKNOWN_DICT,
51+
UNKNOWN_ENUM_VALUE,
4952
)
5053
from ads.aqua.data import AquaResourceIdentifier
5154
from ads.aqua.model import AquaModelApp
@@ -864,21 +867,26 @@ def list(self, **kwargs) -> List["AquaDeployment"]:
864867

865868
if oci_aqua:
866869
# skipping the AQUA model deployments that are created from model group
867-
# TODO: remove this checker after AQUA deployment is integrated with model group
868-
aqua_model_id = model_deployment.freeform_tags.get(
869-
Tags.AQUA_MODEL_ID_TAG, UNKNOWN
870-
)
871870
if (
872-
"datasciencemodelgroup" in aqua_model_id
873-
or model_deployment.model_deployment_configuration_details.deployment_type
874-
== "UNKNOWN_ENUM_VALUE"
871+
model_deployment.model_deployment_configuration_details.deployment_type
872+
in [UNKNOWN_ENUM_VALUE, MODEL_GROUP, SINGLE_MODEL_FLEX]
875873
):
876874
continue
877-
results.append(
878-
AquaDeployment.from_oci_model_deployment(
879-
model_deployment, self.region
875+
try:
876+
results.append(
877+
AquaDeployment.from_oci_model_deployment(
878+
model_deployment, self.region
879+
)
880880
)
881-
)
881+
except Exception as e:
882+
logger.error(
883+
f"There was an issue processing the list of model deployments . Error: {str(e)}",
884+
exc_info=True,
885+
)
886+
raise AquaRuntimeError(
887+
f"There was an issue processing the list of model deployments . Error: {str(e)}"
888+
) from e
889+
882890
# log telemetry if MD is in active or failed state
883891
deployment_id = model_deployment.id
884892
state = model_deployment.lifecycle_state.upper()

0 commit comments

Comments
 (0)