fix: update error logging format for CMAB fetch failures

Author: FarhanAnjum-opti

optimizely/decision_service.py

@@ -164,7 +164,7 @@ def _get_decision_for_cmab_experiment(
         except Exception as e:
             error_message = Errors.CMAB_FETCH_FAILED_DETAILED.format(experiment.key)
             if self.logger:
-                self.logger.error(f"{error_message} - {str(e)}")
+                self.logger.error(f"{error_message} {str(e)}")
             return {
                 "error": True,
                 "result": None,

optimizely/helpers/enums.py

@@ -127,9 +127,9 @@ class Errors:
     ODP_INVALID_DATA: Final = 'ODP data is not valid.'
     ODP_INVALID_ACTION: Final = 'ODP action is not valid (cannot be empty).'
     MISSING_SDK_KEY: Final = 'SDK key not provided/cannot be found in the datafile.'
-    CMAB_FETCH_FAILED: Final = 'CMAB decision fetch failed with status: {}'
-    INVALID_CMAB_FETCH_RESPONSE: Final = 'Invalid CMAB fetch response'
-    CMAB_FETCH_FAILED_DETAILED: Final = 'Failed to fetch CMAB data for experiment {}'
+    CMAB_FETCH_FAILED: Final = 'CMAB decision fetch failed with status: {}.'
+    INVALID_CMAB_FETCH_RESPONSE: Final = 'Invalid CMAB fetch response.'
+    CMAB_FETCH_FAILED_DETAILED: Final = 'Failed to fetch CMAB data for experiment {}.'
 
 
 class ForcedDecisionLogs:

tests/test_decision_service.py

@@ -988,7 +988,7 @@ def test_get_variation_cmab_experiment_deep_mock_500_error(self):
             self.assertIn(detailed_error_message, reasons)
 
             # Verify logger was called with the specific 500 error
-            mock_logger.error.assert_any_call(f'{detailed_error_message} - {error_message}')
+            mock_logger.error.assert_any_call(f'{detailed_error_message} {error_message}')
 
     def test_get_variation_cmab_experiment_forced_variation(self):
         """Test get_variation with CMAB experiment when user has a forced variation."""