Skip to content

Commit ba28ba6

Browse files
raju-optiraju-opti
authored
[FSSDK-11090] remove unused log messages (#988)
1 parent 9adc544 commit ba28ba6

File tree

10 files changed

+31
-88
lines changed

10 files changed

+31
-88
lines changed

‎lib/core/decision_service/index.ts‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@ import {
6161
import {
6262
SAVED_USER_VARIATION,
6363
SAVED_VARIATION_NOT_FOUND,
64-
USER_HAS_FORCED_DECISION_WITH_NO_RULE_SPECIFIED,
65-
USER_HAS_FORCED_DECISION_WITH_NO_RULE_SPECIFIED_BUT_INVALID,
66-
USER_HAS_FORCED_DECISION_WITH_RULE_SPECIFIED,
67-
USER_HAS_FORCED_DECISION_WITH_RULE_SPECIFIED_BUT_INVALID,
6864
USER_HAS_NO_FORCED_VARIATION,
6965
USER_MAPPED_TO_FORCED_VARIATION,
7066
USER_HAS_NO_FORCED_VARIATION_FOR_EXPERIMENT,
@@ -98,6 +94,14 @@ export const IMPROPERLY_FORMATTED_EXPERIMENT = 'Experiment key %s is improperly
9894
export const USER_HAS_FORCED_VARIATION =
9995
'Variation %s is mapped to experiment %s and user %s in the forced variation map.';
10096
export const USER_MEETS_CONDITIONS_FOR_TARGETING_RULE = 'User %s meets conditions for targeting rule %s.';
97+
export const USER_HAS_FORCED_DECISION_WITH_RULE_SPECIFIED =
98+
'Variation (%s) is mapped to flag (%s), rule (%s) and user (%s) in the forced decision map.';
99+
export const USER_HAS_FORCED_DECISION_WITH_NO_RULE_SPECIFIED =
100+
'Variation (%s) is mapped to flag (%s) and user (%s) in the forced decision map.';
101+
export const USER_HAS_FORCED_DECISION_WITH_RULE_SPECIFIED_BUT_INVALID =
102+
'Invalid variation is mapped to flag (%s), rule (%s) and user (%s) in the forced decision map.';
103+
export const USER_HAS_FORCED_DECISION_WITH_NO_RULE_SPECIFIED_BUT_INVALID =
104+
'Invalid variation is mapped to flag (%s) and user (%s) in the forced decision map.';
101105

102106
export interface DecisionObj {
103107
experiment: Experiment | null;

‎lib/message/error_message.ts‎

Lines changed: 8 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2024, Optimizely
2+
* Copyright 2024-2025, Optimizely
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -14,14 +14,9 @@
1414
* limitations under the License.
1515
*/
1616
export const NOTIFICATION_LISTENER_EXCEPTION = 'Notification listener for (%s) threw exception: %s';
17-
export const BROWSER_ODP_MANAGER_INITIALIZATION_FAILED = '%s: Error initializing Browser ODP Manager.';
1817
export const CONDITION_EVALUATOR_ERROR = 'Error evaluating audience condition of type %s: %s';
19-
export const DATAFILE_AND_SDK_KEY_MISSING =
20-
'%s: You must provide at least one of sdkKey or datafile. Cannot start Optimizely';
2118
export const EXPERIMENT_KEY_NOT_IN_DATAFILE = 'Experiment key %s is not in datafile.';
2219
export const FEATURE_NOT_IN_DATAFILE = 'Feature key %s is not in datafile.';
23-
export const FETCH_SEGMENTS_FAILED_NETWORK_ERROR = '%s: Audience segments fetch failed. (network error)';
24-
export const FETCH_SEGMENTS_FAILED_DECODE_ERROR = '%s: Audience segments fetch failed. (decode error)';
2520
export const INVALID_ATTRIBUTES = 'Provided attributes are in an invalid format.';
2621
export const INVALID_BUCKETING_ID = 'Unable to generate hash for bucketing ID %s: %s';
2722
export const INVALID_DATAFILE = 'Datafile is invalid - property %s: %s';
@@ -38,45 +33,18 @@ export const INVALID_GROUP_ID = 'Group ID %s is not in datafile.';
3833
export const INVALID_LOGGER = 'Provided "logger" is in an invalid format.';
3934
export const INVALID_USER_ID = 'Provided user ID is in an invalid format.';
4035
export const INVALID_USER_PROFILE_SERVICE = 'Provided user profile service instance is in an invalid format: %s.';
41-
export const LOCAL_STORAGE_DOES_NOT_EXIST = 'Error accessing window localStorage.';
4236
export const MISSING_INTEGRATION_KEY =
4337
'Integration key missing from datafile. All integrations should include a key.';
4438
export const NO_DATAFILE_SPECIFIED = 'No datafile specified. Cannot start optimizely.';
4539
export const NO_JSON_PROVIDED = 'No JSON object to validate against schema.';
4640
export const NO_EVENT_PROCESSOR = 'No event processor is provided';
4741
export const NO_VARIATION_FOR_EXPERIMENT_KEY = 'No variation key %s defined in datafile for experiment %s.';
48-
export const ODP_CONFIG_NOT_AVAILABLE = '%s: ODP is not integrated to the project.';
42+
export const ODP_CONFIG_NOT_AVAILABLE = 'ODP config is not available.';
4943
export const ODP_EVENT_FAILED = 'ODP event send failed.';
5044
export const ODP_EVENT_MANAGER_IS_NOT_RUNNING = 'ODP event manager is not running.';
5145
export const ODP_EVENTS_SHOULD_HAVE_ATLEAST_ONE_KEY_VALUE = 'ODP events should have at least one key-value pair in identifiers.';
52-
export const ODP_FETCH_QUALIFIED_SEGMENTS_SEGMENTS_MANAGER_MISSING =
53-
'%s: ODP unable to fetch qualified segments (Segments Manager not initialized).';
54-
export const ODP_IDENTIFY_FAILED_EVENT_MANAGER_MISSING =
55-
'%s: ODP identify event %s is not dispatched (Event Manager not instantiated).';
56-
export const ODP_INITIALIZATION_FAILED = '%s: ODP failed to initialize.';
57-
export const ODP_INVALID_DATA = '%s: ODP data is not valid';
58-
export const ODP_EVENT_FAILED_ODP_MANAGER_MISSING = '%s: ODP Event failed to send. (ODP Manager not initialized).';
59-
export const ODP_FETCH_QUALIFIED_SEGMENTS_FAILED_ODP_MANAGER_MISSING =
60-
'%s: ODP failed to Fetch Qualified Segments. (ODP Manager not initialized).';
61-
export const ODP_IDENTIFY_USER_FAILED_ODP_MANAGER_MISSING =
62-
'%s: ODP failed to Identify User. (ODP Manager not initialized).';
63-
export const ODP_IDENTIFY_USER_FAILED_USER_CONTEXT_INITIALIZATION =
64-
'%s: ODP failed to Identify User. (Failed during User Context Initialization).';
65-
export const ODP_MANAGER_UPDATE_SETTINGS_FAILED_EVENT_MANAGER_MISSING =
66-
'%s: ODP Manager failed to update OdpConfig settings for internal event manager. (Event Manager not initialized).';
67-
export const ODP_MANAGER_UPDATE_SETTINGS_FAILED_SEGMENTS_MANAGER_MISSING =
68-
'%s: ODP Manager failed to update OdpConfig settings for internal segments manager. (Segments Manager not initialized).';
69-
export const ODP_NOT_ENABLED = 'ODP is not enabled';
70-
export const ODP_NOT_INTEGRATED = '%s: ODP is not integrated';
71-
export const ODP_SEND_EVENT_FAILED_EVENT_MANAGER_MISSING =
72-
'%s: ODP send event %s was not dispatched (Event Manager not instantiated).';
73-
export const ODP_SEND_EVENT_FAILED_UID_MISSING =
74-
'%s: ODP send event %s was not dispatched (No valid user identifier provided).';
75-
export const ODP_SEND_EVENT_FAILED_VUID_MISSING = '%s: ODP send event %s was not dispatched (Unable to fetch VUID).';
76-
export const ODP_VUID_INITIALIZATION_FAILED = '%s: ODP VUID initialization failed.';
77-
export const ODP_VUID_REGISTRATION_FAILED = '%s: ODP VUID failed to be registered.';
78-
export const ODP_VUID_REGISTRATION_FAILED_EVENT_MANAGER_MISSING =
79-
'%s: ODP register vuid failed. (Event Manager not instantiated).';
46+
export const ODP_EVENT_FAILED_ODP_MANAGER_MISSING = 'ODP Event failed to send. (ODP Manager not available).';
47+
export const ODP_NOT_INTEGRATED = 'ODP is not integrated';
8048
export const UNDEFINED_ATTRIBUTE = 'Provided attribute: %s has an undefined value.';
8149
export const UNRECOGNIZED_ATTRIBUTE =
8250
'Unrecognized attribute %s provided. Pruning before sending event to Optimizely.';
@@ -86,17 +54,15 @@ export const USER_NOT_IN_FORCED_VARIATION =
8654
export const USER_PROFILE_LOOKUP_ERROR = 'Error while looking up user profile for user ID "%s": %s.';
8755
export const USER_PROFILE_SAVE_ERROR = 'Error while saving user profile for user ID "%s": %s.';
8856
export const VARIABLE_KEY_NOT_IN_DATAFILE =
89-
'%s: Variable with key "%s" associated with feature with key "%s" is not in datafile.';
90-
export const VARIATION_ID_NOT_IN_DATAFILE = '%s: No variation ID %s defined in datafile for experiment %s.';
91-
export const VARIATION_ID_NOT_IN_DATAFILE_NO_EXPERIMENT = 'Variation ID %s is not in the datafile.';
57+
'Variable with key "%s" associated with feature with key "%s" is not in datafile.';
58+
export const VARIATION_ID_NOT_IN_DATAFILE = 'Variation ID %s is not in the datafile.';
9259
export const INVALID_INPUT_FORMAT = 'Provided %s is in an invalid format.';
9360
export const INVALID_DATAFILE_VERSION =
9461
'This version of the JavaScript SDK does not support the given datafile version: %s';
9562
export const INVALID_VARIATION_KEY = 'Provided variation key is in an invalid format.';
96-
export const UNABLE_TO_GET_VUID = 'Unable to get VUID - ODP Manager is not instantiated yet.';
9763
export const ERROR_FETCHING_DATAFILE = 'Error fetching datafile: %s';
9864
export const DATAFILE_FETCH_REQUEST_FAILED = 'Datafile fetch request failed with status: %s';
99-
export const EVENT_DATA_FOUND_TO_BE_INVALID = 'Event data found to be invalid.';
65+
export const EVENT_DATA_INVALID = 'Event data invalid.';
10066
export const EVENT_ACTION_INVALID = 'Event action invalid.';
10167
export const FAILED_TO_SEND_ODP_EVENTS = 'failed to send odp events';
10268
export const UNABLE_TO_GET_VUID_VUID_MANAGER_NOT_AVAILABLE = 'Unable to get VUID - VuidManager is not available'
@@ -135,13 +101,10 @@ export const SEND_BEACON_FAILED = 'sendBeacon failed';
135101
export const FAILED_TO_DISPATCH_EVENTS = 'Failed to dispatch events'
136102
export const FAILED_TO_DISPATCH_EVENTS_WITH_ARG = 'Failed to dispatch events: %s';
137103
export const EVENT_PROCESSOR_STOPPED = 'Event processor stopped before it could be started';
138-
export const CANNOT_START_WITHOUT_ODP_CONFIG = 'cannot start without ODP config';
139-
export const START_CALLED_WHEN_ODP_IS_NOT_INTEGRATED = 'start() called when ODP is not integrated';
140-
export const ODP_ACTION_IS_NOT_VALID = 'ODP action is not valid (cannot be empty).';
141104
export const ODP_MANAGER_STOPPED_BEFORE_RUNNING = 'odp manager stopped before running';
142105
export const ODP_EVENT_MANAGER_STOPPED = "ODP event manager stopped before it could start";
143-
export const ONREADY_TIMEOUT_EXPIRED = 'onReady timeout expired after %s ms';
144106
export const DATAFILE_MANAGER_FAILED_TO_START = 'Datafile manager failed to start';
145107
export const UNABLE_TO_ATTACH_UNLOAD = 'unable to bind optimizely.close() to page unload event: "%s"';
108+
export const UNABLE_TO_PARSE_AND_SKIPPED_HEADER = 'Unable to parse & skipped header item';
146109

147110
export const messages: string[] = [];

‎lib/message/log_message.ts‎

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -14,47 +14,24 @@
1414
* limitations under the License.
1515
*/
1616

17-
export const ACTIVATE_USER = '%s: Activating user %s in experiment %s.';
18-
export const DISPATCH_CONVERSION_EVENT = '%s: Dispatching conversion event to URL %s with params %s.';
19-
export const DISPATCH_IMPRESSION_EVENT = '%s: Dispatching impression event to URL %s with params %s.';
20-
export const DEPRECATED_EVENT_VALUE = '%s: Event value is deprecated in %s call.';
2117
export const FEATURE_ENABLED_FOR_USER = 'Feature %s is enabled for user %s.';
2218
export const FEATURE_NOT_ENABLED_FOR_USER = 'Feature %s is not enabled for user %s.';
23-
export const FAILED_TO_PARSE_VALUE = '%s: Failed to parse event value "%s" from event tags.';
19+
export const FAILED_TO_PARSE_VALUE = 'Failed to parse event value "%s" from event tags.';
2420
export const FAILED_TO_PARSE_REVENUE = 'Failed to parse revenue value "%s" from event tags.';
2521
export const INVALID_CLIENT_ENGINE = 'Invalid client engine passed: %s. Defaulting to node-sdk.';
26-
export const INVALID_DEFAULT_DECIDE_OPTIONS = '%s: Provided default decide options is not an array.';
22+
export const INVALID_DEFAULT_DECIDE_OPTIONS = 'Provided default decide options is not an array.';
2723
export const INVALID_DECIDE_OPTIONS = 'Provided decide options is not an array. Using default decide options.';
2824
export const NOT_ACTIVATING_USER = 'Not activating user %s for experiment %s.';
29-
export const ODP_DISABLED = 'ODP Disabled.';
30-
export const ODP_IDENTIFY_FAILED_ODP_DISABLED = '%s: ODP identify event for user %s is not dispatched (ODP disabled).';
31-
export const ODP_IDENTIFY_FAILED_ODP_NOT_INTEGRATED =
32-
'%s: ODP identify event %s is not dispatched (ODP not integrated).';
33-
export const ODP_SEND_EVENT_IDENTIFIER_CONVERSION_FAILED =
34-
'%s: sendOdpEvent failed to parse through and convert fs_user_id aliases';
3525
export const PARSED_REVENUE_VALUE = 'Parsed revenue value "%s" from event tags.';
3626
export const PARSED_NUMERIC_VALUE = 'Parsed event value "%s" from event tags.';
3727
export const SAVED_USER_VARIATION = 'Saved user profile for user "%s".';
38-
export const UPDATED_USER_VARIATION = '%s: Updated variation "%s" of experiment "%s" for user "%s".';
3928
export const SAVED_VARIATION_NOT_FOUND =
4029
'User %s was previously bucketed into variation with ID %s for experiment %s, but no matching variation was found.';
4130
export const SHOULD_NOT_DISPATCH_ACTIVATE = 'Experiment %s is not in "Running" state. Not activating user.';
4231
export const SKIPPING_JSON_VALIDATION = 'Skipping JSON schema validation.';
4332
export const TRACK_EVENT = 'Tracking event %s for user %s.';
44-
export const USER_IN_FEATURE_EXPERIMENT = '%s: User %s is in variation %s of experiment %s on the feature %s.';
45-
export const USER_NOT_BUCKETED_INTO_EVERYONE_TARGETING_RULE =
46-
'%s: User %s not bucketed into everyone targeting rule due to traffic allocation.';
47-
export const USER_NOT_BUCKETED_INTO_ANY_EXPERIMENT_IN_GROUP = '%s: User %s is not in any experiment of group %s.';
4833
export const USER_MAPPED_TO_FORCED_VARIATION =
4934
'Set variation %s for experiment %s and user %s in the forced variation map.';
50-
export const USER_HAS_FORCED_DECISION_WITH_RULE_SPECIFIED =
51-
'Variation (%s) is mapped to flag (%s), rule (%s) and user (%s) in the forced decision map.';
52-
export const USER_HAS_FORCED_DECISION_WITH_NO_RULE_SPECIFIED =
53-
'Variation (%s) is mapped to flag (%s) and user (%s) in the forced decision map.';
54-
export const USER_HAS_FORCED_DECISION_WITH_RULE_SPECIFIED_BUT_INVALID =
55-
'Invalid variation is mapped to flag (%s), rule (%s) and user (%s) in the forced decision map.';
56-
export const USER_HAS_FORCED_DECISION_WITH_NO_RULE_SPECIFIED_BUT_INVALID =
57-
'Invalid variation is mapped to flag (%s) and user (%s) in the forced decision map.';
5835
export const USER_HAS_NO_FORCED_VARIATION = 'User %s is not in the forced variation map.';
5936
export const USER_RECEIVED_DEFAULT_VARIABLE_VALUE =
6037
'User "%s" is not in any variation or rollout rule. Returning default value for variable "%s" of feature flag "%s".';
@@ -75,12 +52,13 @@ export const MISSING_ATTRIBUTE_VALUE =
7552
export const UNEXPECTED_TYPE_NULL =
7653
'Audience condition %s evaluated to UNKNOWN because a null value was passed for user attribute "%s".';
7754
export const UPDATED_OPTIMIZELY_CONFIG = 'Updated Optimizely config to revision %s (project id %s)';
78-
export const UNABLE_TO_PARSE_AND_SKIPPED_HEADER = 'Unable to parse & skipped header item';
7955
export const ADDING_AUTHORIZATION_HEADER_WITH_BEARER_TOKEN = 'Adding Authorization header with Bearer Token';
8056
export const MAKING_DATAFILE_REQ_TO_URL_WITH_HEADERS = 'Making datafile request to url %s with headers: %s';
8157
export const RESPONSE_STATUS_CODE = 'Response status code: %s';
8258
export const SAVED_LAST_MODIFIED_HEADER_VALUE_FROM_RESPONSE = 'Saved last modified header value from response: %s';
8359
export const USER_HAS_NO_FORCED_VARIATION_FOR_EXPERIMENT =
8460
'No experiment %s mapped to user %s in the forced variation map.';
61+
export const INVALID_EXPERIMENT_KEY_INFO =
62+
'Experiment key %s is not in datafile. It is either invalid, paused, or archived.';
8563

8664
export const messages: string[] = [];

‎lib/odp/event_manager/odp_event_manager.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { isSuccessStatusCode } from '../../utils/http_request_handler/http_util'
2525
import { ODP_DEFAULT_EVENT_TYPE, ODP_USER_KEY } from '../constant';
2626
import {
2727
EVENT_ACTION_INVALID,
28-
EVENT_DATA_FOUND_TO_BE_INVALID,
28+
EVENT_DATA_INVALID,
2929
FAILED_TO_SEND_ODP_EVENTS,
3030
ODP_EVENT_MANAGER_IS_NOT_RUNNING,
3131
ODP_EVENTS_SHOULD_HAVE_ATLEAST_ONE_KEY_VALUE,
@@ -179,7 +179,7 @@ export class DefaultOdpEventManager extends BaseService implements OdpEventManag
179179
}
180180

181181
if (!this.isDataValid(event.data)) {
182-
this.logger?.error(EVENT_DATA_FOUND_TO_BE_INVALID);
182+
this.logger?.error(EVENT_DATA_INVALID);
183183
return;
184184
}
185185

‎lib/optimizely/index.tests.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ import {
5858
NO_VARIATION_FOR_EXPERIMENT_KEY,
5959
USER_NOT_IN_FORCED_VARIATION,
6060
INSTANCE_CLOSED,
61-
ONREADY_TIMEOUT_EXPIRED,
61+
ONREADY_TIMEOUT,
6262
} from 'error_message';
6363

6464
import {
@@ -9466,7 +9466,7 @@ describe('lib/optimizely', function() {
94669466
return readyPromise.then(() => {
94679467
return Promise.reject(new Error('PROMISE_SHOULD_NOT_HAVE_RESOLVED'));
94689468
}, (err) => {
9469-
assert.equal(err.baseMessage, ONREADY_TIMEOUT_EXPIRED);
9469+
assert.equal(err.baseMessage, ONREADY_TIMEOUT);
94709470
assert.deepEqual(err.params, [ 500 ]);
94719471
});
94729472
});
@@ -9491,7 +9491,7 @@ describe('lib/optimizely', function() {
94919491
return readyPromise.then(() => {
94929492
return Promise.reject(new Error(PROMISE_SHOULD_NOT_HAVE_RESOLVED));
94939493
}, (err) => {
9494-
assert.equal(err.baseMessage, ONREADY_TIMEOUT_EXPIRED);
9494+
assert.equal(err.baseMessage, ONREADY_TIMEOUT);
94959495
assert.deepEqual(err.params, [ 30000 ]);
94969496
});
94979497
});

‎lib/optimizely/index.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ import { resolvablePromise } from '../utils/promise/resolvablePromise';
6666
import { NOTIFICATION_TYPES, DecisionNotificationType, DECISION_NOTIFICATION_TYPES } from '../notification_center/type';
6767
import {
6868
FEATURE_NOT_IN_DATAFILE,
69-
INVALID_EXPERIMENT_KEY,
7069
INVALID_INPUT_FORMAT,
7170
NO_EVENT_PROCESSOR,
7271
ODP_EVENT_FAILED,
@@ -88,6 +87,7 @@ import {
8887
INVALID_CLIENT_ENGINE,
8988
INVALID_DECIDE_OPTIONS,
9089
INVALID_DEFAULT_DECIDE_OPTIONS,
90+
INVALID_EXPERIMENT_KEY_INFO,
9191
NOT_ACTIVATING_USER,
9292
SHOULD_NOT_DISPATCH_ACTIVATE,
9393
TRACK_EVENT,
@@ -452,7 +452,7 @@ export default class Optimizely implements Client {
452452

453453
const experiment = configObj.experimentKeyMap[experimentKey];
454454
if (!experiment || experiment.isRollout) {
455-
this.logger?.debug(INVALID_EXPERIMENT_KEY, experimentKey);
455+
this.logger?.debug(INVALID_EXPERIMENT_KEY_INFO, experimentKey);
456456
return null;
457457
}
458458

‎lib/optimizely_user_context/index.tests.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import {
3333
USER_HAS_FORCED_DECISION_WITH_NO_RULE_SPECIFIED_BUT_INVALID,
3434
USER_HAS_FORCED_DECISION_WITH_RULE_SPECIFIED,
3535
USER_HAS_FORCED_DECISION_WITH_RULE_SPECIFIED_BUT_INVALID,
36-
} from 'log_message';
36+
} from '../core/decision_service';
3737

3838
const getMockEventDispatcher = () => {
3939
const dispatcher = {

‎lib/project_config/polling_datafile_manager.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ export class PollingDatafileManager extends BaseService implements DatafileManag
115115
this.startPromise.reject(new OptimizelyError(DATAFILE_MANAGER_STOPPED));
116116
}
117117

118-
this.logger?.debug(DATAFILE_MANAGER_STOPPED);
119118
this.state = ServiceState.Terminated;
120119
this.repeater.stop();
121120
this.currentRequest?.abort();

‎lib/project_config/project_config.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ import {
4747
UNEXPECTED_RESERVED_ATTRIBUTE_PREFIX,
4848
UNRECOGNIZED_ATTRIBUTE,
4949
VARIABLE_KEY_NOT_IN_DATAFILE,
50-
VARIATION_ID_NOT_IN_DATAFILE_NO_EXPERIMENT,
50+
VARIATION_ID_NOT_IN_DATAFILE,
5151
} from 'error_message';
5252
import { SKIPPING_JSON_VALIDATION, VALID_DATAFILE } from 'log_message';
5353
import { OptimizelyError } from '../error/optimizly_error';
@@ -693,7 +693,7 @@ export const getVariableValueForVariation = function(
693693
}
694694

695695
if (!projectConfig.variationVariableUsageMap.hasOwnProperty(variation.id)) {
696-
logger?.error(VARIATION_ID_NOT_IN_DATAFILE_NO_EXPERIMENT, variation.id);
696+
logger?.error(VARIATION_ID_NOT_IN_DATAFILE, variation.id);
697697
return null;
698698
}
699699

‎lib/utils/http_request_handler/request_handler.browser.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717
import { AbortableRequest, Headers, RequestHandler, Response } from './http';
1818
import { LoggerFacade, LogLevel } from '../../logging/logger';
1919
import { REQUEST_TIMEOUT_MS } from '../enums';
20-
import { REQUEST_ERROR, REQUEST_TIMEOUT } from 'error_message';
21-
import { UNABLE_TO_PARSE_AND_SKIPPED_HEADER } from 'log_message';
20+
import { REQUEST_ERROR, REQUEST_TIMEOUT, UNABLE_TO_PARSE_AND_SKIPPED_HEADER } from 'error_message';
2221
import { OptimizelyError } from '../../error/optimizly_error';
2322

2423
/**

0 commit comments

Comments
 (0)