opti fix

Author: raju-opti

lib/optimizely/index.tests.js

@@ -37,16 +37,13 @@ import { getMockProjectConfigManager } from '../tests/mock/mock_project_config_m
 import { DECISION_NOTIFICATION_TYPES } from '../notification_center/type';
 import {
   AUDIENCE_EVALUATION_RESULT_COMBINED,
-  EVENT_KEY_NOT_FOUND,
   EXPERIMENT_NOT_RUNNING,
   FEATURE_HAS_NO_EXPERIMENTS,
   FEATURE_NOT_ENABLED_FOR_USER,
-  FORCED_BUCKETING_FAILED,
   INVALID_CLIENT_ENGINE,
   INVALID_DEFAULT_DECIDE_OPTIONS,
   INVALID_OBJECT,
   NOT_ACTIVATING_USER,
-  NOT_TRACKING_USER,
   RETURNING_STORED_VARIATION,
   USER_DOESNT_MEET_CONDITIONS_FOR_TARGETING_RULE,
   USER_FORCED_IN_VARIATION,
@@ -67,10 +64,13 @@ import {
 import {
   EXPERIMENT_KEY_NOT_IN_DATAFILE,
   INVALID_ATTRIBUTES,
+  NOT_TRACKING_USER,
+  EVENT_KEY_NOT_FOUND,
   INVALID_EXPERIMENT_KEY,
   INVALID_INPUT_FORMAT,
   NO_VARIATION_FOR_EXPERIMENT_KEY,
   USER_NOT_IN_FORCED_VARIATION,
+  FORCED_BUCKETING_FAILED,
 } from '../error_messages';
 import { FAILED_TO_STOP, ONREADY_TIMEOUT_EXPIRED, PROMISE_SHOULD_NOT_HAVE_RESOLVED } from '../exception_messages';
 import { USER_BUCKETED_INTO_EXPERIMENT_IN_GROUP } from '../core/bucketer';
@@ -1627,27 +1627,24 @@ describe('lib/optimizely', function() {
         // assert.strictEqual(logMessage, sprintf(INVALID_INPUT_FORMAT, 'OPTIMIZELY', 'user_id'));
       });
 
-      it.skip('should log a warning for an event key that is not in the datafile and a warning for not tracking user', function() {
-        optlyInstance.track('invalidEventKey', 'testUser');
+      it('should log a warning for an event key that is not in the datafile and a warning for not tracking user', function() {
+        const { optlyInstance, errorNotifier, createdLogger, eventDispatcher } = getOptlyInstance({
+          datafileObj: testData.getTestDecideProjectConfig(),
+        });
 
-        sinon.assert.calledTwice(createdLogger.log);
+        sinon.stub(createdLogger, 'warn');
+
+        optlyInstance.track('invalidEventKey', 'testUser');
 
-        var logCall1 = createdLogger.log.getCall(0);
         sinon.assert.calledWithExactly(
-          // createLogger.warn,
-          logCall1,
-          LOG_LEVEL.WARNING,
+          createdLogger.warn,
           EVENT_KEY_NOT_FOUND,
-          'OPTIMIZELY',
           'invalidEventKey'
         );
 
-        var logCall2 = createdLogger.log.getCall(1);
         sinon.assert.calledWithExactly(
-          logCall2,
-          LOG_LEVEL.WARNING,
+          createdLogger.warn,
           NOT_TRACKING_USER,
-          'OPTIMIZELY',
           'testUser'
         );
 
@@ -5153,7 +5150,7 @@ describe('lib/optimizely', function() {
           );
         });
 
-        it.skip('should include reason when invalid forced variation found', function() {
+        it('should include reason when invalid forced variation found', function() {
           var flagKey = 'feature_1';
           var variationKey = 'invalid-key';
           var newConfig = optlyInstance.projectConfigManager.getConfig();

lib/optimizely/index.ts

@@ -379,7 +379,10 @@ export default class Optimizely implements Client {
         return;
       }
 
+      console.log(eventKey, userId, attributes, eventTags);
+
       if (!projectConfig.eventWithKeyExists(configObj, eventKey)) {
+        console.log('eventKey not found',);
         this.logger?.warn(EVENT_KEY_NOT_FOUND, eventKey);
         this.logger?.warn(NOT_TRACKING_USER, userId);
         return;