[FSSDK-11177] review update

Author: junaed-optimizely

OptimizelySDK.Tests/CmabTests/DecisionServiceCmabTest.cs

@@ -179,7 +179,7 @@ public void TestGetVariationWithCmabExperimentServiceError()
 
             Assert.IsNotNull(result);
             Assert.IsNull(result.ResultObject.Variation, "Should return null on error");
-            Assert.IsTrue(result.ResultObject.CmabError);
+            Assert.IsTrue(result.ResultObject.Error);
 
             var reasonsList = result.DecisionReasons.ToReport(true);
 

OptimizelySDK/Bucketing/DecisionService.cs

@@ -812,7 +812,7 @@ public virtual Result<FeatureDecision> GetVariationForFeatureExperiment(
 #if USE_CMAB
                     cmabUuid = variationResult?.CmabUuid;
 
-                    if (variationResult?.CmabError == true)
+                    if (variationResult?.Error == true)
                     {
                         Logger.Log(LogLevel.ERROR,
                             reasons.AddInfo(

OptimizelySDK/Bucketing/VariationDecisionResult.cs

@@ -24,12 +24,12 @@ namespace OptimizelySDK.Bucketing
     public class VariationDecisionResult
     {
         public VariationDecisionResult(Variation variation, string cmabUuid = null,
-            bool cmabError = false
+            bool error = false
         )
         {
             Variation = variation;
             CmabUuid = cmabUuid;
-            CmabError = cmabError;
+            Error = error;
         }
 
         /// <summary>
@@ -43,9 +43,9 @@ public VariationDecisionResult(Variation variation, string cmabUuid = null,
         public string CmabUuid { get; set; }
 
         /// <summary>
-        ///     Indicates whether an error occurred during the CMAB decision process.
-        ///     False for non-CMAB experiments or successful CMAB decisions.
+        ///     Indicates whether an error occurred during the decision process.
+        ///     False for successful decisions or when no error occurred.
         /// </summary>
-        public bool CmabError { get; set; }
+        public bool Error { get; set; }
     }
 }

OptimizelySDK/Cmab/CmabConstants.cs

@@ -35,7 +35,7 @@ internal static class CmabConstants
             "Failed to fetch CMAB data for experiment {0}.";
 
         public static readonly TimeSpan MAX_TIMEOUT = TimeSpan.FromSeconds(10);
-        public static readonly TimeSpan DEFAULT_CACHE_TTL = TimeSpan.FromMinutes(10);
+        public static readonly TimeSpan DEFAULT_CACHE_TTL = TimeSpan.FromMinutes(30);
 
         public const int CMAB_MAX_RETRIES = 1;
         public static readonly TimeSpan CMAB_INITIAL_BACKOFF = TimeSpan.FromMilliseconds(100);