additional unit tests

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/TemporaryResourceCache.java

@@ -189,8 +189,7 @@ public synchronized void putResource(T newResource) {
     }
 
     var ns = newResource.getMetadata().getNamespace();
-    // todo unit test
-    // this can happen when we dynamically change the NS
+    // this can happen when we dynamically change the followed namespace list
     if (!managedInformerEventSource.manager().isWatchingNamespace(ns)) {
       log.debug(
           "Skipping caching of resource: {} since namespace is now watched: {}", resourceId, ns);
@@ -247,7 +246,6 @@ private void checkGhostResources() {
       var e = iterator.next();
 
       var ns = e.getValue().getMetadata().getNamespace();
-      // todo unit tests
       // this can happen if followed namespaces are changed dynamically
       if (!managedInformerEventSource.manager().isWatchingNamespace(ns)) {
         log.debug(

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/TemporaryResourceCacheTest.java

@@ -385,6 +385,42 @@ void ghostResourceIsNotRemovedIfLatestSyncVersionIsOlder() {
                     .isPresent());
   }
 
+  @Test
+  void ghostRemovalRemovesResourcesOnNotFollowedNamespaces() {
+    withTemporaryResourceCacheForGhostHandling();
+
+    var tr = testResource();
+    temporaryResourceCache.putResource(tr);
+
+    assertThat(temporaryResourceCache.getResourceFromCache(ResourceID.fromResource(tr)))
+        .isPresent();
+
+    // simulate namespace no longer being watched
+    var mim = managedInformerEventSource.manager();
+    when(mim.isWatchingNamespace(tr.getMetadata().getNamespace())).thenReturn(false);
+
+    await()
+        .untilAsserted(
+            () ->
+                assertThat(temporaryResourceCache.getResourceFromCache(ResourceID.fromResource(tr)))
+                    .isEmpty());
+
+    // no delete event should be fired for resources removed due to namespace change
+    verify(managedInformerEventSource, times(0))
+        .handleEvent(any(), any(), any(), any(Boolean.class));
+  }
+
+  @Test
+  void doNotCacheResourceOnPutIfNamespaceIsNotFollowedAnymore() {
+    var mim = managedInformerEventSource.manager();
+    when(mim.isWatchingNamespace("default")).thenReturn(false);
+
+    var tr = testResource();
+    temporaryResourceCache.putResource(tr);
+
+    assertThat(temporaryResourceCache.getResourceFromCache(ResourceID.fromResource(tr))).isEmpty();
+  }
+
   private void withTemporaryResourceCacheForGhostHandling() {
     this.temporaryResourceCache =
         new TemporaryResourceCache<>(