decide if we want to validate thrift on pull request or not

[codefromthecrypt]

Unlike swagger and proto, there's no pure javascript tool to validate or use thrifts. You have to rely on a OS binary to first generate the code. This means our travis config either has to invoke two tools or we have a binary dependency in our validate.test.js only for thrift.

another option is to simply not bother with thrift checking as we don't add anything to it anymore.

cc @apache/zipkin-committers

[codefromthecrypt]

fwiw we've never validated thrift on pull request, and incidentally until today even swagger validation was busted!

Now, we validate swagger and proto on pull request.

[jcchavezs]

I would not add validation for now as we are not changing it. Even if change I would not try to validate or until the necessity of a big change. tir. 30. apr. 2019, 05:39 skrev Adrian Cole <[email protected]>:

…

fwiw we've never validated thrift on pull request, and incidentally until today even swagger validation was busted! Now, we validate swagger and proto on pull request. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXOYAWSNXUD6LANPM4C5NTPS65NTANCNFSM4HJIIVOQ> .

[jeqo]

I'm with @jcchavezs, if we don't add anything to thrift anymore, we should not add validation.

[codefromthecrypt]

rule of three