Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests with Jenkins #73

Merged
merged 3 commits into from
May 6, 2019
Merged

Tests with Jenkins #73

merged 3 commits into from
May 6, 2019

Conversation

jeqo
Copy link
Member

@jeqo jeqo commented May 5, 2019

Fixes #67

@codefromthecrypt
Copy link
Member

might be more direct to run the tests directly (ie not maven) but I think considering we are already using maven to publish a snapshot, sgtm.

verified the build output included passing tests.

@codefromthecrypt codefromthecrypt merged commit bc3cd4a into master May 6, 2019
@codefromthecrypt codefromthecrypt deleted the jenkins-test branch May 6, 2019 04:17
@jeqo
Copy link
Member Author

jeqo commented May 6, 2019

@adriancole yes, I tried running nodejs directly first, but I wasn't able to find it (probably not installed on jenkins?) https://builds.apache.org/job/incubator-zipkin-api/job/jenkins-test/1/console

@codefromthecrypt
Copy link
Member

I would have done the same as you.. progress not perfection :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make jenkins run same tests travis does
2 participants