Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broke #62

Closed
codefromthecrypt opened this issue Apr 17, 2019 · 5 comments
Closed

broke #62

codefromthecrypt opened this issue Apr 17, 2019 · 5 comments

Comments

@codefromthecrypt
Copy link
Member

@zhouyaohua noticed after the ASF move the zipkin uri is busted https://zipkin.io/zipkin-api/#/default/get_services

I assume this is related to the move, but we also merged a change recently to the swagger

@codefromthecrypt
Copy link
Member Author

@abesto can you save us?

@codefromthecrypt
Copy link
Member Author

@abesto
Copy link
Member

abesto commented Apr 21, 2019

Well crap, not sure how I missed this. Checking now.

abesto added a commit to openzipkin/openzipkin.github.io that referenced this issue Apr 21, 2019
abesto added a commit to openzipkin/openzipkin.github.io that referenced this issue Apr 21, 2019
@abesto
Copy link
Member

abesto commented Apr 21, 2019

Sooo here's what's up.

Originally this repo was openzipkin/zipkin-api, configured to be served via GitHub pages. GH maps openzipkin/zipkin-api to openzipkin.github.io/zipkin-api, and so things were good (including with the custom domain zipkin.io). Once the repo moved to under apache, this mapping of course broke.

My immediate band-aid was copying the contents into openzipkin/openzipkin.github.io, to the folder zipkin-api. This means the contents can now be reached, except index.html MUST be supplied now, as GH Pages only does automatic index.html resolution at the root of each repository, which this has now stopped being.

So this means any URL https://zipkin.io/zipkin-api/$1 is now available at https://zipkin.io/zipkin-api/index.html$1. Case in point, for the URL in the original report, https://zipkin.io/zipkin-api/index.html#/default/get_services is now available. Unfortunately I don't see a way of making the URL work as it did before. Plus, I think the effort we'd spend looking for workarounds to get rid of the explicit index.html is better spent on migrating to zipkin.apache.org.

@adriancole I'll leave this open so any user-facing communication or whatever else can be tracked here.

abesto added a commit to openzipkin/openzipkin.github.io that referenced this issue Apr 21, 2019
@abesto
Copy link
Member

abesto commented Apr 21, 2019

Huh, weird. Meanwhile https://zipkin.io/zipkin-api/#/default/get_services came back, so I guess index.html just took a bit to propagate to the home-page. That means this is now fully mitigated with no need for user-facing communication. Closing.

@abesto abesto closed this as completed Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants