Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto3 encoding #39

Closed
codefromthecrypt opened this issue Nov 17, 2017 · 1 comment · Fixed by #47
Closed

proto3 encoding #39

codefromthecrypt opened this issue Nov 17, 2017 · 1 comment · Fixed by #47

Comments

@codefromthecrypt
Copy link
Member

through various issues, seems proto3 is the preferred binary format for the span v2 model. We have some decisions to make, mostly around parity with ids and ips.

For example, we can choose to encode the hex ids as raw bytes (half the size of them)
We can also choose to encode IP addresses literals as raw bytes (sliding scale for ipv6; always smaller for ipv4)

Main thing is that if we do choose a binary encoding for proto3 ids and ips, there's a chance users will encode IDs incorrectly (ex encode IDs as uppercase hex, or '0x' prefixed or worse base64). There's a chance folks will handle ip raw bytes inconsistently (ex we consistently marshal ipv6 format so exact match always works).

thoughts? @openzipkin/core

@codefromthecrypt
Copy link
Member Author

codefromthecrypt commented Nov 17, 2017

to help with this, I can take an example trace and encode both ways in proto3 to see what the size difference is. then I can gzip it and see what the size difference is (many transports do gzip)

codefromthecrypt pushed a commit that referenced this issue Apr 23, 2018
codefromthecrypt pushed a commit that referenced this issue Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant