Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParentId missing from Span definition #16

Closed
singram opened this issue Jun 17, 2016 · 2 comments
Closed

ParentId missing from Span definition #16

singram opened this issue Jun 17, 2016 · 2 comments

Comments

@singram
Copy link
Contributor

singram commented Jun 17, 2016

Swagger span definition is missing parentId
singram pushed a commit to singram/zipkin-api that referenced this issue Jun 17, 2016
Added span.parentId parameter. Added descriptions for span parameters…
ba1e151 
… and link to published API.

Resolved openzipkin#16
@singram singram mentioned this issue Jun 17, 2016
Merged
@codefromthecrypt
Copy link
Member

codefromthecrypt commented Jun 21, 2016 via email

@singram
Copy link
Contributor Author

singram commented Jun 21, 2016

@adriancole np, noted! Wasn't too sure of the commit culture around this. Thanks

codefromthecrypt pushed a commit that referenced this issue Jun 23, 2016
@singram @adriancole
Added span.parentId parameter. Added descriptions for span parameter… (…
3bf29a8 
…#17)

Adds descriptions for span parameters and link to published API.

Fixes #16

* Field descriptions ammeded inline with review feedback.
codefromthecrypt pushed a commit that referenced this issue Jun 23, 2016
@singram
Added span.parentId parameter. Added descriptions for span parameter… (…
211a4bd 
…#17)

Adds descriptions for span parameters and link to published API.

Fixes #16

* Field descriptions ammeded inline with review feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codefromthecrypt @singram