Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Store node name in v1beta2.Nodepool spec #2295

Closed
tnsimon opened this issue Feb 3, 2025 · 2 comments · Fixed by #2297
Closed

[feature request] Store node name in v1beta2.Nodepool spec #2295

tnsimon opened this issue Feb 3, 2025 · 2 comments · Fixed by #2297
Labels
kind/feature kind/feature

Comments

@tnsimon
Copy link
Contributor

tnsimon commented Feb 3, 2025

What would you like to be added:
Store node name in v1beta2.Nodepool spec.

Why is this needed:
When yurt-hub starts, it needs to know whether it is the leader. Currently only the node Internal Ip is stored. Keeping the node name also will help.

others
/kind feature

@tnsimon tnsimon added the kind/feature kind/feature label Feb 3, 2025
@tnsimon
Copy link
Contributor Author

tnsimon commented Feb 3, 2025

/assign @tnsimon

@rambohe-ch
Copy link
Member

@tnsimon Yes, It's a good idea to add node name information into leader endpoints, then Yurthub component can resolve this information for deciding the forwarded destination of requests for pool scope requests(like list/watch services, endpointslices).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants