feat: build iot system configuration isolation on nodepool #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LavenderQAQ
requested changes
Sep 16, 2024
WoShiZhangmingyu
force-pushed
the
issue1597
branch
from
8e5efb4 to
0ac69b8
Compare
LavenderQAQ
requested changes
Oct 26, 2024
pkg/yurtmanager/webhook/platformadmin/v1alpha2/platformadmin_validation.go
Outdated
Show resolved
Hide resolved
pkg/yurtmanager/webhook/platformadmin/v1alpha2/platformadmin_validation_test.go
Outdated
Show resolved
Hide resolved
WoShiZhangmingyu
force-pushed
the
issue1597
branch
2 times, most recently
from
8092a7d to
51bc6cf
Compare
LavenderQAQ
requested changes
Oct 28, 2024
WoShiZhangmingyu
force-pushed
the
issue1597
branch
from
51bc6cf to
37a7780
Compare
LavenderQAQ
requested changes
Oct 28, 2024
LavenderQAQ
requested changes
Oct 28, 2024
LavenderQAQ
requested changes
Oct 28, 2024
pkg/yurtmanager/controller/platformadmin/platform_admin_controller_test.go
Outdated
Show resolved
Hide resolved
WoShiZhangmingyu
force-pushed
the
issue1597
branch
from
3c98e2d to
94c5e28
Compare
WoShiZhangmingyu
force-pushed
the
issue1597
branch
from
94c5e28 to
9e2331e
Compare
LavenderQAQ
changed the title
… lint issues Signed-off-by: LavenderQAQ <[email protected]>
Signed-off-by: LavenderQAQ <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#2135
Which issue(s) this PR fixes:
Fixes #1597
Special notes for your reviewer:
@LavenderQAQ
Does this PR introduce a user-facing change?
Yes, users need to change the original version of "pooName" to "nodePools" when creating platformadmin using "kubectl apply".