[Fix] 500 error by enforcing valid UUID patterns in admin URLs #682

Fixes #682

Author: Unnati-Gupta24

openwisp_controller/config/tests/utils.py

@@ -9,7 +9,6 @@
 from uuid import uuid4
 
 from django.db.utils import DEFAULT_DB_ALIAS
-from django.http import HttpResponse
 from openwisp_ipam.tests import CreateModelsMixin as CreateIpamModelsMixin
 from swapper import load_model
 
@@ -26,26 +25,6 @@
 Cert = load_model('django_x509', 'Cert')
 
 
-class TestUtilsMixin:
-    """
-    Mixin for testing utility functions from utils.py
-    """
-    def _create_http_request(self, ip='127.0.0.1', management_ip=None):
-        class MockRequest:
-            META = {'REMOTE_ADDR': ip}
-            GET = {}
-            
-        request = MockRequest()
-        if management_ip:
-            request.GET['management_ip'] = management_ip
-        return request
-
-    def _create_controller_response(self, content='', content_type='text/plain', status=200):
-        response = HttpResponse(content, content_type=content_type, status=status)
-        response['X-Openwisp-Controller'] = 'true'
-        return response
-
-
 class CreateDeviceMixin(TestOrganizationMixin):
     TEST_MAC_ADDRESS = '00:11:22:33:44:55'
 

openwisp_controller/config/utils.py

@@ -1,4 +1,5 @@
 import logging
+import re
 
 from django.core.exceptions import ValidationError
 from django.db.models import Q
@@ -9,6 +10,9 @@
 
 logger = logging.getLogger(__name__)
 
+# Define UUID_PATTERN for URL regular expressions
+UUID_PATTERN = r'[0-9a-fA-F]{8}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{12}'
+
 
 def get_object_or_404(model, **kwargs):
     """