Skip to content

Commit b554277

Browse files
authored
[chore:fix] Fixed custom attribute example + test #413
Fixes #413
1 parent 628db98 commit b554277

File tree

3 files changed

+25
-4
lines changed

3 files changed

+25
-4
lines changed

public/example_templates/netjsongraph-elementsLegend.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
<link href="../lib/css/netjsongraph-theme.css" rel="stylesheet" />
88
<link href="../lib/css/netjsongraph.css" rel="stylesheet" />
99
<style>
10-
#container {
10+
html, body {
1111
width: 100%;
1212
height: 100%;
13-
overflow: hidden;
14-
overflow-y: scroll;
13+
margin: 0;
14+
padding: 0;
1515
}
1616

1717
#legend h4 {
@@ -217,4 +217,4 @@ <h4>Legends</h4>
217217
graph.render();
218218
</script>
219219
</body>
220-
</html>
220+
</html>

test/browser.test.utils.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export const urls = {
3434
basicUsage: `${url}/examples/netjsongraph.html`,
3535
geographicMap: `${url}/examples/netjsonmap.html`,
3636
indoorMap: `${url}/examples/netjsonmap-indoormap.html`,
37+
customAttributes: `${url}/examples/netjsongraph-elementsLegend.html`,
3738
};
3839

3940
export const getElementByCss = async (driver, css, waitTime = 1000) => {

test/netjsongraph.browser.test.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,4 +92,24 @@ describe("Chart Rendering Test", () => {
9292
expect(nodesRendered).toBe(nodesPresent);
9393
expect(linksRendered).toBe(linksPresent);
9494
});
95+
96+
test("render custom attributes example without errors", async () => {
97+
driver.get(urls.customAttributes);
98+
const canvas = await getElementByCss(driver, "canvas", 2000);
99+
const consoleErrors = await captureConsoleErrors(driver);
100+
const {nodesRendered, linksRendered} = await getRenderedNodesAndLinksCount(driver);
101+
printConsoleErrors(consoleErrors);
102+
expect(consoleErrors.length).toBe(0);
103+
expect(canvas).not.toBeNull();
104+
const canvasHeight = await driver.executeScript(
105+
"return graph.echarts.getRenderedCanvas().height",
106+
);
107+
const windowHeight = await driver.executeScript("return window.innerHeight");
108+
expect(canvasHeight).not.toBe(0);
109+
expect(canvasHeight).toBe(windowHeight);
110+
const nodesCount = await driver.executeScript("return graph.data.nodes.length");
111+
const linksCount = await driver.executeScript("return graph.data.links.length");
112+
expect(nodesCount).toBe(6);
113+
expect(linksCount).toBe(7);
114+
});
95115
});

0 commit comments

Comments
 (0)