Skip to content

Commit 9e5d85c

Browse files
committed
[fix] Add comments and nitpicks
1 parent 91fa176 commit 9e5d85c

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/js/netjsongraph.render.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ class NetJSONGraphRender {
9393
"click",
9494
(params) => {
9595
const clickElement = configs.onClickElement.bind(self);
96-
self.utils.setUrlFragments(self, params);
9796
if (params.componentSubType === "graph") {
9897
return clickElement(
9998
params.dataType === "edge" ? "link" : "node",
@@ -103,6 +102,7 @@ class NetJSONGraphRender {
103102
if (params.componentSubType === "graphGL") {
104103
return clickElement("node", params.data);
105104
}
105+
self.utils.setUrlFragments(self, params);
106106
return params.componentSubType === "lines"
107107
? clickElement("link", params.data.link)
108108
: !params.data.cluster && clickElement("node", params.data.node);
@@ -144,6 +144,7 @@ class NetJSONGraphRender {
144144
// Preserve original NetJSON node for sidebar use
145145
/* eslint-disable no-underscore-dangle */
146146
nodeResult._source = JSON.parse(JSON.stringify(node));
147+
// Store the clicked node in this.selectedNode for easy access later without need for traverse
147148
self.utils.setSelectedNodeFromUrlFragments(self, fragments, node);
148149
return nodeResult;
149150
});
@@ -244,6 +245,7 @@ class NetJSONGraphRender {
244245
});
245246
}
246247
}
248+
// Store the clicked node in this.selectedNode for easy access later without need for traverse
247249
self.utils.setSelectedNodeFromUrlFragments(self, fragments, node);
248250
});
249251
links.forEach((link) => {

src/js/netjsongraph.util.js

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,6 +1193,12 @@ class NetJSONGraphUtil {
11931193
return fragments;
11941194
}
11951195

1196+
generateUrlFragments(fragments) {
1197+
return Object.values(fragments)
1198+
.map((urlParams) => urlParams.toString())
1199+
.join(";");
1200+
}
1201+
11961202
setUrlFragments(self, params) {
11971203
if (!self.config.urlFragments.show) return;
11981204
const fragments = this.parseUrlFragments();
@@ -1213,11 +1219,7 @@ class NetJSONGraphUtil {
12131219
if (zoom != undefined) {
12141220
fragments[id].set("zoom", zoom);
12151221
}
1216-
const newHash = Object.values(fragments)
1217-
.map((urlParams) => urlParams.toString())
1218-
.join(";");
1219-
1220-
window.location.hash = newHash;
1222+
window.location.hash = this.generateUrlFragments(fragments);
12211223
}
12221224

12231225
removeUrlFragment(self) {
@@ -1228,11 +1230,7 @@ class NetJSONGraphUtil {
12281230
if (fragments[id]) {
12291231
delete fragments[id];
12301232
}
1231-
const newHash = Object.values(fragments)
1232-
.map((urlParams) => urlParams.toString())
1233-
.join(";");
1234-
1235-
window.location.hash = newHash;
1233+
window.location.hash = this.generateUrlFragments(fragments);
12361234
}
12371235

12381236
setSelectedNodeFromUrlFragments(self, fragments, node) {

0 commit comments

Comments
 (0)