Skip to content

Commit 0c1311a

Browse files
committed
[fix] Add comments and nitpicks
1 parent bfb585f commit 0c1311a

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/js/netjsongraph.render.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ class NetJSONGraphRender {
9393
"click",
9494
(params) => {
9595
const clickElement = configs.onClickElement.bind(self);
96-
self.utils.setUrlFragments(self, params);
9796
if (params.componentSubType === "graph") {
9897
return clickElement(
9998
params.dataType === "edge" ? "link" : "node",
@@ -103,6 +102,7 @@ class NetJSONGraphRender {
103102
if (params.componentSubType === "graphGL") {
104103
return clickElement("node", params.data);
105104
}
105+
self.utils.setUrlFragments(self, params);
106106
return params.componentSubType === "lines"
107107
? clickElement("link", params.data.link)
108108
: !params.data.cluster && clickElement("node", params.data.node);
@@ -152,6 +152,7 @@ class NetJSONGraphRender {
152152
// Preserve original NetJSON node for sidebar use
153153
/* eslint-disable no-underscore-dangle */
154154
nodeResult._source = JSON.parse(JSON.stringify(node));
155+
// Store the clicked node in this.selectedNode for easy access later without need for traverse
155156
self.utils.setSelectedNodeFromUrlFragments(self, fragments, node);
156157
return nodeResult;
157158
});
@@ -292,6 +293,7 @@ class NetJSONGraphRender {
292293
});
293294
}
294295
}
296+
// Store the clicked node in this.selectedNode for easy access later without need for traverse
295297
self.utils.setSelectedNodeFromUrlFragments(self, fragments, node);
296298
});
297299
links.forEach((link) => {

src/js/netjsongraph.util.js

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,6 +1207,12 @@ class NetJSONGraphUtil {
12071207
return fragments;
12081208
}
12091209

1210+
generateUrlFragments(fragments) {
1211+
return Object.values(fragments)
1212+
.map((urlParams) => urlParams.toString())
1213+
.join(";");
1214+
}
1215+
12101216
setUrlFragments(self, params) {
12111217
if (!self.config.urlFragments.show) return;
12121218
const fragments = this.parseUrlFragments();
@@ -1227,11 +1233,7 @@ class NetJSONGraphUtil {
12271233
if (zoom != undefined) {
12281234
fragments[id].set("zoom", zoom);
12291235
}
1230-
const newHash = Object.values(fragments)
1231-
.map((urlParams) => urlParams.toString())
1232-
.join(";");
1233-
1234-
window.location.hash = newHash;
1236+
window.location.hash = this.generateUrlFragments(fragments);
12351237
}
12361238

12371239
removeUrlFragment(self) {
@@ -1242,11 +1244,7 @@ class NetJSONGraphUtil {
12421244
if (fragments[id]) {
12431245
delete fragments[id];
12441246
}
1245-
const newHash = Object.values(fragments)
1246-
.map((urlParams) => urlParams.toString())
1247-
.join(";");
1248-
1249-
window.location.hash = newHash;
1247+
window.location.hash = this.generateUrlFragments(fragments);
12501248
}
12511249

12521250
setSelectedNodeFromUrlFragments(self, fragments, node) {

0 commit comments

Comments
 (0)