Remove "positive violations" and invert score.

Now all violations are really violations.  There is no need for the
"positive violations".  The score is now purely a badness score.  The
higher the score, the more work is needed to fix the problem.  A score
of 0 means the problem has no issues.

The "positive violations" were really going to be a problem if the
intent of the score is to obtain a measure of how much work is needed to
fix a problem and make it conform to current best-practices in problem
authoring.  For example, a problem could do quite a bit wrong but have a
custom checker.  The custom checker score was really high, and so that
would offset the things done wrong and it might end up with a score that
is the same as for a problem that only does a few things wrong, but
doesn't have a custom checker.  So that first problem with the custom
checker really needs a lot of work, but the second problem without the
checker only needs trivial fixes.  By only having a badness score you
get a much clearer measure of how much is needed to update a problem to
conform with current best-practices.

Author: drgrice1

bin/pg-critic.pl

@@ -16,18 +16,18 @@ =head1 SYNOPSIS
                         JavaScript Object Notation.
     -o|--output-file    Filename to write output to. If not provided output will
                         be printed to STDOUT.
-    -n|--no-details     Only show the filename and score and do not include the
-                        details in the output for each file.
+    -n|--no-details     Only show the filename and badness score and do not
+                        include the details in the output for each file.
     -s|--strict         Disable "## no critic" annotations and force all
                         policies to be enforced.
     -h|--help           Show the help message.
 
 =head1 DESCRIPTION
 
 C<pg-critic.pl> is a PG problem source code analyzer.  It is the executable
-front-end to the L<WeBWorK::PG::Critic> module, which attempts to identify
-usage of old or deprecated PG features, as well as usage of newer features and
-current best practices in coding a problem.
+front-end to the L<WeBWorK::PG::Critic> module, which attempts to identify usage
+of old or deprecated PG features and code that does not conform to current
+best-practices.
 
 =cut
 
@@ -70,9 +70,9 @@ (@violations)
 		if ($_->policy =~ /^Perl::Critic::Policy::PG::/) {
 			$score += $_->explanation->{score} // 0;
 		} else {
-			# Deduct 5 points for any of the default Perl::Critic::Policy violations.
+			# Add 5 points for any of the default Perl::Critic::Policy violations.
 			# These will not have a score in the explanation.
-			$score -= 5;
+			$score += 5;
 		}
 	}
 	return $score;
@@ -83,13 +83,10 @@ (@violations)
 for (@ARGV) {
 	my @violations = critiquePGFile($_, $force);
 
-	my (@positivePGResults, @negativePGResults, @perlCriticResults);
+	my (@pgCriticViolations, @perlCriticViolations);
 	if (!$noDetails) {
-		@positivePGResults =
-			grep { $_->policy =~ /^Perl::Critic::Policy::PG::/ && $_->explanation->{score} > 0 } @violations;
-		@negativePGResults =
-			grep { $_->policy =~ /^Perl::Critic::Policy::PG::/ && $_->explanation->{score} < 0 } @violations;
-		@perlCriticResults = grep { $_->policy !~ /^Perl::Critic::Policy::PG::/ } @violations;
+		@pgCriticViolations   = grep { $_->policy =~ /^Perl::Critic::Policy::PG::/ } @violations;
+		@perlCriticViolations = grep { $_->policy !~ /^Perl::Critic::Policy::PG::/ } @violations;
 	}
 
 	push(
@@ -99,11 +96,7 @@ (@violations)
 			score => scoreProblem(@violations),
 			$noDetails
 			? ()
-			: (
-				positivePGResults => \@positivePGResults,
-				negativePGResults => \@negativePGResults,
-				perlCriticResults => \@perlCriticResults
-			)
+			: (pgCriticViolations => \@pgCriticViolations, perlCriticViolations => \@perlCriticViolations)
 		}
 	);
 }
@@ -116,16 +109,13 @@ (@violations)
 	return join(
 		"\n",
 		map { (
-			"filename: $_->{file}",
-			"score: $_->{score}",
-			@{ $_->{positivePGResults} // [] }
-			? ('positive pg critic results:', map { "\t" . $_->to_string } @{ $_->{positivePGResults} })
+			"Filename: $_->{file}",
+			"Score: $_->{score}",
+			@{ $_->{pgCriticViolations} // [] }
+			? ('PG critic violations:', map { "\t" . $_->to_string } @{ $_->{pgCriticViolations} })
 			: (),
-			@{ $_->{negativePGResults} // [] }
-			? ('negative pg critic results:', map { "\t" . $_->to_string } @{ $_->{negativePGResults} })
-			: (),
-			@{ $_->{perlCriticResults} // [] }
-			? ('perl critic results:', map { "\t" . $_->to_string } @{ $_->{perlCriticResults} })
+			@{ $_->{perlCriticViolations} // [] }
+			? ('Perl critic violations:', map { "\t" . $_->to_string } @{ $_->{perlCriticViolations} })
 			: ()
 		) } @$results
 	);