Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The QUIC connection object created from listener is not quite right #960

Closed
Sashan opened this issue Dec 12, 2024 · 2 comments
Closed

The QUIC connection object created from listener is not quite right #960

Sashan opened this issue Dec 12, 2024 · 2 comments
Assignees

Comments

@Sashan
Copy link

Sashan commented Dec 12, 2024

This is related to this change here:

@@ -1284,7 +1297,13 @@ static int ch_on_transport_params(const unsigned char *params,
             }
 
             /* Must match SCID of first Initial packet from server. */
-            if (!ossl_quic_conn_id_eq(&ch->init_scid, &cid)) {
+            if (cid.id_len != 0 &&  !ossl_quic_conn_id_eq(&ch->init_scid, &cid)) {
                 reason = TP_REASON_EXPECTED_VALUE("INITIAL_SCID");
                 goto malformed;
             }

t8m has asked about it during the code review here.

I agree the change above is kind of a workaround which allows handshake to complete when application is connecting using QUIC object created by SSL_new_from_listener()

I'm also attaching a wireshark dump which shows yet another difference.quic.pcapng.gz

Not the first connection from client to localhost:4444, the initial packet carries DCID only.

the connection where server uses SSL connection object created by SSL_new_from_listener() (packet 52) carries DCID as well SCID. This might be related to the thing I'm hunting for.

@Sashan Sashan self-assigned this Dec 12, 2024
@github-project-automation github-project-automation bot moved this to Pre-Refinement in Development Board Dec 12, 2024
@Sashan Sashan moved this from Pre-Refinement to In Progress in Development Board Dec 12, 2024
@Sashan
Copy link
Author

Sashan commented Dec 12, 2024

this is the follow up on 25851

@Sashan Sashan moved this from In Progress to Waiting Review in Development Board Dec 13, 2024
@Sashan Sashan moved this from New to Awaits review in Project Board Dec 13, 2024
@Sashan
Copy link
Author

Sashan commented Jan 9, 2025

PR openssl/openssl#26138 has been pushed.

@Sashan Sashan closed this as completed Jan 9, 2025
@github-project-automation github-project-automation bot moved this from Awaits review to Done in Project Board Jan 9, 2025
@github-project-automation github-project-automation bot moved this from Waiting Review to Done in Development Board Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants