Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate interop multiplexing test failed for server #949

Closed
Tracked by #944
nhorman opened this issue Dec 3, 2024 · 2 comments
Closed
Tracked by #944

Investigate interop multiplexing test failed for server #949

nhorman opened this issue Dec 3, 2024 · 2 comments
Assignees

Comments

@nhorman
Copy link
Contributor

nhorman commented Dec 3, 2024

The quic-interop-runner multiplexing test failed. The logs indicate that, while all files were served by the server and downloaded by the client, there was a file size mismatch (32 bytes on the server vs 0 bytes on the client) on one of the sent files.

Checking the logs it appears the short file (which is randomly generated by the test harness) was named bsyynqphdv, and the request was sent, but the server interpreted the name as bsyynqp (i.e. truncated), and as such could not find the file.

Investigation needed to determine why the file was truncated and fix it. Likely a server application issue

@nhorman nhorman changed the title multiplexing test failed interop multiplexing test failed for server Dec 3, 2024
@nhorman nhorman removed this from Project Board Dec 3, 2024
@github-project-automation github-project-automation bot moved this to Pre-Refinement in Development Board Dec 3, 2024
@Sashan
Copy link

Sashan commented Dec 9, 2024

failure in interop, I think we should fix the code to pass this test.

@nhorman
Copy link
Contributor Author

nhorman commented Dec 16, 2024

problem appears to be a server side issue. Based on captured log data:

client  | Client creates stream id 2416 for request /downloads/sjmfldilrd   <= client sends full file name
...
server  | Server queues new stream 2416
...
server  | Reading from stream id 2416
...
server  | Request is GET /sjmfldi   <= Server reads truncated file name

it appears that the server is only reading part of the request here. That appears to occur when, according to the related tcpdump:
image

image

That the server assume such short http requests will always be satisfied in a single read, but when the data is split across stream packets, thats not the case. We need to handle short reads and ensure that we get all the data in the request

@nhorman nhorman moved this from In Progress to Waiting Review in Development Board Dec 17, 2024
nhorman added a commit to nhorman/openssl that referenced this issue Dec 18, 2024
@nhorman nhorman closed this as completed Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Waiting Review to Done in Development Board Jan 6, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Project Board Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Refining to Done in Project Board 3.5.0 planning Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Status: Done
3 participants