Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QUIC tests to allow server to retrieve remote address of client #933

Closed
andrewkdinh opened this issue Nov 26, 2024 · 1 comment
Closed

Update QUIC tests to allow server to retrieve remote address of client #933

andrewkdinh opened this issue Nov 26, 2024 · 1 comment

Comments

@andrewkdinh
Copy link

Any test that calls qtest_create_quic_objects will create a server/client combo that uses a dgram_pair to communicate. The problem is that peers won't have a remote address since everything is done in memory. Any attempts for server validation to validate the peer remote address fails because it's always NULL. The solution likely involves updating bss_dgram_pair to allow setting an initial peer.

Required for tests in openssl/openssl#26048 to pass.
@andrewkdinh andrewkdinh converted this from a draft issue Nov 26, 2024
@andrewkdinh andrewkdinh mentioned this issue Nov 26, 2024
Closed
2 tasks
mattcaswell added a commit to mattcaswell/openssl that referenced this issue Nov 26, 2024
@mattcaswell
Add the ablity to set a local address for BIO_dgram_pair
9e8a3fb 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933
@mattcaswell mattcaswell mentioned this issue Nov 26, 2024
Closed
andrewkdinh pushed a commit to andrewkdinh/openssl that referenced this issue Nov 27, 2024
@mattcaswell @andrewkdinh
Add the ablity to set a local address for BIO_dgram_pair
78eb76c 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933
openssl-machine pushed a commit to openssl/openssl that referenced this issue Nov 28, 2024
@mattcaswell
Add the ablity to set a local address for BIO_dgram_pair
0ec3d50 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from #26066)
@andrewkdinh
Copy link
Author

Completed with openssl/openssl#26066

@github-project-automation github-project-automation bot moved this from New to Done in Project Board Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Pre-Refinement to Done in Development Board Dec 9, 2024
nhorman pushed a commit to nhorman/openssl that referenced this issue Jan 7, 2025
@mattcaswell @nhorman
Add the ablity to set a local address for BIO_dgram_pair
656bec0 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
nhorman pushed a commit to nhorman/openssl that referenced this issue Jan 9, 2025
@mattcaswell @nhorman
Add the ablity to set a local address for BIO_dgram_pair
999d4db 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
nhorman pushed a commit to nhorman/openssl that referenced this issue Jan 11, 2025
@mattcaswell @nhorman
Add the ablity to set a local address for BIO_dgram_pair
ae5d2f4 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
nhorman pushed a commit to nhorman/openssl that referenced this issue Feb 4, 2025
@mattcaswell @nhorman
Add the ablity to set a local address for BIO_dgram_pair
ddedea9 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
nhorman pushed a commit to openssl/openssl that referenced this issue Feb 7, 2025
@mattcaswell @nhorman
Add the ablity to set a local address for BIO_dgram_pair
30235a6 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from #26066)
andrewkdinh pushed a commit to andrewkdinh/openssl that referenced this issue Feb 14, 2025
@mattcaswell @andrewkdinh
Add the ablity to set a local address for BIO_dgram_pair
819d331 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
nhorman pushed a commit to nhorman/openssl that referenced this issue Feb 14, 2025
@mattcaswell @nhorman
Add the ablity to set a local address for BIO_dgram_pair
c166a74 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
nhorman pushed a commit to nhorman/openssl that referenced this issue Feb 14, 2025
@mattcaswell @nhorman
Add the ablity to set a local address for BIO_dgram_pair
ca00c1d 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
nhorman pushed a commit to openssl/openssl that referenced this issue Feb 17, 2025
@mattcaswell @nhorman
Add the ablity to set a local address for BIO_dgram_pair
906f7d8 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from #26066)
nhorman pushed a commit to nhorman/openssl that referenced this issue Feb 17, 2025
@mattcaswell @nhorman
Add the ablity to set a local address for BIO_dgram_pair
16a1900 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
Sashan pushed a commit to vdukhovni/openssl that referenced this issue Feb 19, 2025
@mattcaswell @Sashan
Add the ablity to set a local address for BIO_dgram_pair
ab24bfc 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
definability pushed a commit to definability/openssl that referenced this issue Feb 25, 2025
@mattcaswell @definability
Add the ablity to set a local address for BIO_dgram_pair
330973d 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
quarckster pushed a commit to quarckster/openssl-fork that referenced this issue Feb 27, 2025
@mattcaswell @quarckster
Add the ablity to set a local address for BIO_dgram_pair
aff55f1 
BIOs created from a BIO_dgram_pair don't normally have a local BIO_ADDR
associated with them. This allows us to set one.

Fixes openssl/project#933

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
(Merged from openssl#26066)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Development Board
Status: Done
Project Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewkdinh