Skip to content

TwoFrameLinker updateFromXMLNode() does not handle offset frames correctly #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisdembia opened this issue Jun 8, 2017 · 1 comment

Comments

@chrisdembia
Copy link
Member

Right now, the updateFromXMLNode() code for TwoFrameLinker will add offset frames if the location/orientation properties are nonzero, but the code will not properly set the socket connectee names to point to these offset frames. Instead, the connectee names remain as the original bodies specified in the old model.

The intent of this line was to set the connectee name to the offset frame, but it actually has no effect.

@chrisdembia
Copy link
Member Author

I've created a fix, but it is intertwined with my progress on #1751. I might try to separate out the fix into a self-contained PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants