Merge pull request #2582 from opensim-org/ignore_timing_testC3D_appveyor

Introduce symbol SKIP_TIMING to control timing section of testC3DFileAdapter

Author: aymanhab

OpenSim/Common/Test/testC3DFileAdapter.cpp

@@ -170,8 +170,8 @@ void test(const std::string filename) {
     loadTime = 1.e3*(std::clock() - t0) / CLOCKS_PER_SEC;
     cout << "\tC3DFileAdapter '" << filename << "' read with forces at COP in "
         << loadTime << "ms" << endl;
-
-    #ifdef NDEBUG
+    // on ci-biulds will define SKIP_TIMING as it is unpredictably slow on some machines
+    #if defined(NDEBUG) && !defined(SKIP_TIMING)
     ASSERT(loadTime < MaximumLoadTimeInMS, __FILE__, __LINE__,
         "Unable to load '" + filename + "' within " +
         to_string(MaximumLoadTimeInMS) + "ms.");

appveyor.yml

@@ -103,7 +103,8 @@ build_script:
   - cd %OPENSIM_BUILD_DIR%
   # Configure. # TODO -DBUILD_SIMM_TRANSLATOR=ON
   # Set the CXXFLAGS environment variable to turn warnings into errors.
-  - cmake -E env CXXFLAGS="/WX" cmake %OPENSIM_SOURCE_DIR% -G"%CMAKE_GENERATOR%" -T"%CMAKE_TOOLSET%" -DSIMBODY_HOME=C:\simbody%NUGET_PACKAGE_ID_SUFFIX% -DOPENSIM_DEPENDENCIES_DIR=%OPENSIM_DEPENDENCIES_INSTALL_DIR% -DCMAKE_INSTALL_PREFIX=%OPENSIM_INSTALL_DIR% -DBUILD_JAVA_WRAPPING=ON -DBUILD_PYTHON_WRAPPING=ON -DWITH_BTK:BOOL=ON
+  # Skip timing test section included by default
+  - cmake -E env CXXFLAGS="/WX -DSKIP_TIMING" cmake %OPENSIM_SOURCE_DIR% -G"%CMAKE_GENERATOR%" -T"%CMAKE_TOOLSET%" -DSIMBODY_HOME=C:\simbody%NUGET_PACKAGE_ID_SUFFIX% -DOPENSIM_DEPENDENCIES_DIR=%OPENSIM_DEPENDENCIES_INSTALL_DIR% -DCMAKE_INSTALL_PREFIX=%OPENSIM_INSTALL_DIR% -DBUILD_JAVA_WRAPPING=ON -DBUILD_PYTHON_WRAPPING=ON -DWITH_BTK:BOOL=ON
 
   # Build.
   - cmake --build . --config Release -- /maxcpucount:4 /verbosity:quiet #/p:TreatWarningsAsErrors="true"