Add secret name length check (#69362)

* Add secret name length check

* Add secret name length check

* Reword error msg

Author: psalajova

hack/gcp-secret-manager/util.py

@@ -26,6 +26,10 @@
 # The string reserved for the service account secret associated with each collection.
 UPDATER_SA_SECRET_NAME = "updater-service-account"
 
+# GCP limit for a secret name is 255 chars, 200 should be plenty
+# (we must also take into account the collection).
+SECRET_NAME_MAX_LENGTH = 200
+
 
 def ensure_authentication():
     """
@@ -61,6 +65,8 @@ def validate_secret_name(_ctx, _param, value):
         )
     if not re.fullmatch("[A-Za-z0-9-]+", value):
         raise click.BadParameter("May only contain letters, numbers or dashes.")
+    if len(value) > SECRET_NAME_MAX_LENGTH:
+        raise click.BadParameter(f"Secret name must be less than {SECRET_NAME_MAX_LENGTH} characters.")
     return value