networking, virt: generalize conflict detection

This way we can ensure appropriate cases are caught in a generic way.
With it, we can safely expect to find IP conflicts when there are
duplicate IPs in the network.
In future commits, we will be able to catch MAC conflicts when there are
duplicate MACs in the network

Co-authored-by: Ram Lavi <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>

Author: maiqueb

test/extended/networking/livemigration.go

@@ -30,7 +30,10 @@ import (
 	"github.com/openshift/origin/test/extended/util/image"
 )
 
-const kvIPRequestsAnnot = "network.kubevirt.io/addresses"
+const (
+	kvIPRequestsAnnot     = "network.kubevirt.io/addresses"
+	primaryUDNNetworkName = "overlay"
+)
 
 var _ = Describe("[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines", func() {
 	// disable automatic namespace creation, we need to add the required UDN label
@@ -570,14 +573,26 @@ func duplicateVM(cli *kubevirt.Client, vmNamespace, vmName string) {
 	Expect(json.Unmarshal([]byte(originalVMIRawAnnotations), &originalVMIAnnotations)).To(Succeed())
 
 	var vmiCreationOptions []kubevirt.Option
+	var vmiExpectations []func()
 	if requestedIPs, hasIPRequests := originalVMIAnnotations[kvIPRequestsAnnot]; hasIPRequests {
 		vmiCreationOptions = append(
 			vmiCreationOptions,
 			kubevirt.WithAnnotations(ipRequests(requestedIPs)),
 		)
+		vmiExpectations = append(vmiExpectations, func() {
+			waitForVMPodEventWithMessage(
+				cli,
+				vmNamespace,
+				duplicateVMName,
+				"IP is already allocated",
+				2*time.Minute,
+			)
+		})
 	}
 	Expect(cli.CreateVMIFromSpec(vmNamespace, duplicateVMName, vmiSpec, vmiCreationOptions...)).To(Succeed())
-	waitForVMPodEventWithMessage(cli, vmNamespace, duplicateVMName, "IP is already allocated", 2*time.Minute)
+	for _, expectation := range vmiExpectations {
+		expectation()
+	}
 }
 
 func waitForVMPodEventWithMessage(vmClient *kubevirt.Client, vmNamespace, vmName, expectedEventMessage string, timeout time.Duration) {
@@ -788,7 +803,6 @@ func networkName(netSpecConfig string) string {
 
 // formatAddressesAnnotation converts slice of IPs to the required JSON format for kubevirt addresses annotation
 func formatAddressesAnnotation(preconfiguredIPs []string) (string, error) {
-	const primaryUDNNetworkName = "overlay"
 	if len(preconfiguredIPs) == 0 {
 		return "", nil
 	}